Re: [PATCH] D12616: Failing test highlighting no poisoning if dtor undeclared.

2015-09-08 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 34220. nmusgrave marked an inline comment as done. nmusgrave added a comment. - Rename test. http://reviews.llvm.org/D12616 Files: test/CodeGenCXX/sanitize-dtor-trivial.cpp Index: test/CodeGenCXX/sanitize-dtor-trivial.cpp ==

Re: [PATCH] D12616: Failing test highlighting no poisoning if dtor undeclared.

2015-09-04 Thread Evgeniy Stepanov via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. I'd call the test sanitize-dtor-trivial.cpp http://reviews.llvm.org/D12616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: [PATCH] D12616: Failing test highlighting no poisoning if dtor undeclared.

2015-09-04 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 34094. nmusgrave marked an inline comment as done. nmusgrave added a comment. - Only check simplest object for existence of sanitizing callback. http://reviews.llvm.org/D12616 Files: test/CodeGenCXX/sanitize-dtor-generated.cpp Index: test/CodeGenCXX/sa

Re: [PATCH] D12616: Failing test highlighting no poisoning if dtor undeclared.

2015-09-03 Thread Evgeniy Stepanov via cfe-commits
eugenis added inline comments. Comment at: test/CodeGenCXX/sanitize-dtor-generated.cpp:5 @@ +4,3 @@ + +// TODO Success pending on resolution of issue 596 +// XFAIL: * Add the link to the issue. Comment at: test/CodeGenCXX/sanitize-dtor-generated.