aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I've commit in r246494 and r246495.
http://reviews.llvm.org/D12446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D12446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
aaron.ballman updated this revision to Diff 33584.
aaron.ballman added a comment.
Only use a single test file with two RUN lines.
http://reviews.llvm.org/D12446
Files:
clang-tidy/misc/StaticAssertCheck.cpp
test/clang-tidy/check_clang_tidy.py
test/clang-tidy/misc-static-assert.c
Index: te
aaron.ballman added inline comments.
Comment at: test/clang-tidy/misc-static-assert-c99.c:2
@@ +1,3 @@
+// RUN: %python %S/check_clang_tidy.py %s misc-static-assert %t -- -std=c99
+
+void abort() {}
alexfh wrote:
> klimek wrote:
> > aaron.ballman wrote:
> > > I am
klimek added inline comments.
Comment at: test/clang-tidy/misc-static-assert-c99.c:1
@@ +1,2 @@
+// RUN: %python %S/check_clang_tidy.py %s misc-static-assert %t -- -std=c99
+
alexfh wrote:
> Instead of duplicating the test, you could add a second run line in the o
klimek added a subscriber: klimek.
Comment at: test/clang-tidy/misc-static-assert-c99.c:2
@@ +1,3 @@
+// RUN: %python %S/check_clang_tidy.py %s misc-static-assert %t -- -std=c99
+
+void abort() {}
aaron.ballman wrote:
> I am not certain how to accomplish this with
alexfh added inline comments.
Comment at: test/clang-tidy/misc-static-assert-c99.c:2
@@ +1,3 @@
+// RUN: %python %S/check_clang_tidy.py %s misc-static-assert %t -- -std=c99
+
+void abort() {}
aaron.ballman wrote:
> I am not certain how to accomplish this with the
It seems Phab doesn't give you any context for this comment. For
reference, this is in response to the comment:
Instead of duplicating the test, you could add a second run line in
the other test and just verify that clang-tidy doesn't generate any
warnings when run with -std=c99. The invariant "no
aaron.ballman marked an inline comment as done.
Comment at: test/clang-tidy/misc-static-assert-c99.c:2
@@ +1,3 @@
+// RUN: %python %S/check_clang_tidy.py %s misc-static-assert %t -- -std=c99
+
+void abort() {}
I am not certain how to accomplish this with the pytho
aaron.ballman updated this revision to Diff 33579.
aaron.ballman added a comment.
No longer worrying about static_assert() vs _Static_assert(). Corrected Python
script.
http://reviews.llvm.org/D12446
Files:
clang-tidy/misc/StaticAssertCheck.cpp
test/clang-tidy/check_clang_tidy.py
test/cl
alexfh added a comment.
> 1. If is included, then static_assert() is also fine to use.
> Presumably, in order for the assert() check to trigger, has to be
> included, but I don't feel particularly comfortable with that assumption.
Do you have any C11 code that uses `assert()`, but doesn't in
11 matches
Mail list logo
