Re: [PATCH] D12375: [PATCH] Relax parse ordering rules for attributes

2015-08-27 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3923 @@ +3922,3 @@ + +void Parser::MaybeParseAttributes(unsigned WhichAttrKinds, + ParsedAttributesWithRange &Attrs, Please provide an inlineable wrapper for this

Re: [PATCH] D12375: [PATCH] Relax parse ordering rules for attributes

2015-08-27 Thread Aaron Ballman via cfe-commits
aaron.ballman updated this revision to Diff 33318. aaron.ballman added a comment. I've updated the patch to disallow reordering of C++11 attributes with relation to other attribute syntaxes. Additionally, if there is a reordering issue found, we now warn the user. http://reviews.llvm.org/D1237

Re: [PATCH] D12375: [PATCH] Relax parse ordering rules for attributes

2015-08-26 Thread Richard Smith via cfe-commits
On Wed, Aug 26, 2015 at 1:55 PM, Aaron Ballman wrote: > On Wed, Aug 26, 2015 at 4:30 PM, Richard Smith > wrote: > > On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman > > > wrote: > >> > >> aaron.ballman created this revision. > >> aaron.ballman added reviewers: rsmith, hans. > >> aaron.ballman ad

Re: [PATCH] D12375: [PATCH] Relax parse ordering rules for attributes

2015-08-26 Thread Aaron Ballman via cfe-commits
On Wed, Aug 26, 2015 at 4:30 PM, Richard Smith wrote: > On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman > wrote: >> >> aaron.ballman created this revision. >> aaron.ballman added reviewers: rsmith, hans. >> aaron.ballman added a subscriber: cfe-commits. >> >> PR24559 brings up a long-standing iss

Re: [PATCH] D12375: [PATCH] Relax parse ordering rules for attributes

2015-08-26 Thread Richard Smith via cfe-commits
On Wed, Aug 26, 2015 at 11:27 AM, Aaron Ballman wrote: > aaron.ballman created this revision. > aaron.ballman added reviewers: rsmith, hans. > aaron.ballman added a subscriber: cfe-commits. > > PR24559 brings up a long-standing issue in Clang where attribute order > with differing syntax impacts