EricWF abandoned this revision.
EricWF added a comment.
Abandoning in favor of http://reviews.llvm.org/D13407.
http://reviews.llvm.org/D11963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
eugenis added a comment.
Hi Eric, have you had a chance to take another look at this? It is blocking
http://reviews.llvm.org/D11740.
http://reviews.llvm.org/D11963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
eugenis added a subscriber: eugenis.
eugenis added a comment.
This would greatly simplify the abi versioning change in
http://reviews.llvm.org/D11740. Thanks for working on this!
Comment at: include/CMakeLists.txt:24
@@ +23,3 @@
+ -P ${LIBCXX_SOURCE_DIR}/cmake/Modules/CopyLibc
jroelofs added a comment.
Without the context of this review, this strategy probably won't make any
sense. So it's probably worth capturing these notes in a comment that describes
why we're doing it that way.
http://reviews.llvm.org/D11963
___
cfe
EricWF added a comment.
In http://reviews.llvm.org/D11963#236376, @jroelofs wrote:
> In http://reviews.llvm.org/D11963#236045, @EricWF wrote:
>
> > So that's not what happens but that's because libc++ builds using the
> > headers in the source directory. During the build all of the macros in the
jroelofs added a comment.
In http://reviews.llvm.org/D11963#236045, @EricWF wrote:
> So that's not what happens but that's because libc++ builds using the headers
> in the source directory. During the build all of the macros in the
> __config_site file are manually defined on the command line s
EricWF added a comment.
In http://reviews.llvm.org/D11963#235148, @jroelofs wrote:
> In http://reviews.llvm.org/D11963#234789, @EricWF wrote:
>
> > Copy the headers to the build directory during every build instead of just
> > during CMake configuration.
>
>
> Sounds like this would cause every
jroelofs added a comment.
In http://reviews.llvm.org/D11963#234789, @EricWF wrote:
> Copy the headers to the build directory during every build instead of just
> during CMake configuration.
Sounds like this would cause every build to effectively be a full build. I
don't think we want that...
EricWF updated this revision to Diff 33384.
EricWF added a comment.
Copy the headers to the build directory during every build instead of just
during CMake configuration.
http://reviews.llvm.org/D11963
Files:
CMakeLists.txt
cmake/Modules/CopyLibcxxHeaders.cmake
cmake/Modules/HandleLibcxx
EricWF updated the summary for this revision.
EricWF updated this revision to Diff 32997.
EricWF added a comment.
Update diff to remove misc cleanup stuff.
http://reviews.llvm.org/D11963
Files:
CMakeLists.txt
cmake/Modules/HandleLibcxxFlags.cmake
include/CMakeLists.txt
include/__config_
EricWF updated this revision to Diff 32992.
EricWF added a comment.
This patch takes @jroelof's idea and runs with it. However this patch doesn't
require a `__config_site` header. The patch works modifying
`build-libcxx/include/c++/v1/__config` by prepending the contents of
`__config_site`. If
EricWF commandeered this revision.
EricWF edited reviewers, added: jroelofs; removed: EricWF.
EricWF added a comment.
Stealing this revision. I have a different plan.
http://reviews.llvm.org/D11963
___
cfe-commits mailing list
cfe-commits@lists.llvm
jroelofs added a comment.
In http://reviews.llvm.org/D11963#228024, @EricWF wrote:
> Wouldn't it still be a mess if you build both libc++ and libc++abi
> out-of-tree? The user would have to be aware of these weird requirements.
Oh, yeah, true. Do we have any out-of-tree builders to make sure t
EricWF added a comment.
In http://reviews.llvm.org/D11963#227933, @jroelofs wrote:
> In http://reviews.llvm.org/D11963#227444, @EricWF wrote:
>
> > I also just realized that this change will currently likely play havoc with
> > how libc++ and libc++abi build together. In order to build libc++ an
EricWF added a comment.
In http://reviews.llvm.org/D11963#227951, @jroelofs wrote:
> In http://reviews.llvm.org/D11963#227441, @EricWF wrote:
>
> > @jroelofs What do you think of an approach like this?
>
>
> Having two copies of the __config_site file makes me uncomfortable, but I
> could put up
jroelofs added a comment.
In http://reviews.llvm.org/D11963#227441, @EricWF wrote:
> @jroelofs What do you think of an approach like this?
Having two copies of the __config_site file makes me uncomfortable, but I could
put up with that given that they're effectively the same for 99% of people
jroelofs added a comment.
In http://reviews.llvm.org/D11963#227444, @EricWF wrote:
> I also just realized that this change will currently likely play havoc with
> how libc++ and libc++abi build together. In order to build libc++ and
> libc++abi together we would need to
>
> 1. Configure libc++
EricWF added a comment.
I also just realized that this change will currently likely play havoc with how
libc++ and libc++abi build together. In order to build libc++ and libc++abi
together we would need to
1. Configure libc++ pointing to the libc++abi headers in order to generate the
__config_
EricWF added a comment.
I think we can avoid requiring the need to rebuild every time the headers
change but it's not the cleanest. We could
1. Have an empty `__config_site` file in `libcxx/include`. This `__config_site`
file does not get copied into the build directory.
2. Generate `__config_s
jroelofs updated this revision to Diff 31949.
jroelofs added a comment.
Add license text to the new file, and move the two has-no-threads tests to
test/libcxx.
http://reviews.llvm.org/D11963
Files:
CMakeLists.txt
include/CMakeLists.txt
include/__config
include/__config_site.in
test/l
EricWF added a reviewer: EricWF.
EricWF added a comment.
@jroelofs Thanks for this patch. I've needed this for a while.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
jroelofs wrote:
> jroelofs wrote:
> > mclow.lis
jroelofs added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
jroelofs wrote:
> mclow.lists wrote:
> > espositofulvio wrote:
> > > mclow.lists wrote:
> > > > I'm reluctant to do this; because every i
mclow.lists added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
espositofulvio wrote:
> mclow.lists wrote:
> > I'm reluctant to do this; because every include file slows down compilation
> > - for
jroelofs added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
espositofulvio wrote:
> mclow.lists wrote:
> > I'm reluctant to do this; because every include file slows down compilation
> > - for eve
espositofulvio added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
mclow.lists wrote:
> I'm reluctant to do this; because every include file slows down compilation -
> for every program that we com
mclow.lists added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
I'm reluctant to do this; because every include file slows down compilation -
for every program that we compile.
However, this may b
jroelofs updated this revision to Diff 31885.
jroelofs added a comment.
@danalbert: sigh, yes.
http://reviews.llvm.org/D11963
Files:
CMakeLists.txt
include/CMakeLists.txt
include/__config
include/__config_site.in
test/libcxx/test/config.py
test/std/atomics/libcpp-has-no-threads.pass
danalbert added inline comments.
Comment at: CMakeLists.txt:304
@@ +303,3 @@
+configure_file(
+ include/__config_site.in
+ ${CMAKE_BINARY_DIR}/include/c++/v1/__config_site
Did you forget to upload this?
http://reviews.llvm.org/D11963
___
jroelofs updated this revision to Diff 31878.
jroelofs added a comment.
fix typo
http://reviews.llvm.org/D11963
Files:
CMakeLists.txt
include/CMakeLists.txt
include/__config
test/libcxx/test/config.py
test/std/atomics/libcpp-has-no-threads.pass.cpp
test/std/utilities/date.time/teste
29 matches
Mail list logo
