nwilson added a subscriber: nwilson.
nwilson added a comment.
Hi Piotr,
Would you mind renaming the title of the Patch since the title will be
committed as such?
Thanks!
http://reviews.llvm.org/D11928
___
cfe-commits mailing list
cfe-commits@lists
Prazek added inline comments.
Comment at: include/clang/AST/VTableBuilder.h:54
@@ -53,3 +53,3 @@
- VTableComponent() { }
+ VTableComponent() = default;
rnk wrote:
> Is this ctor used? It leaves Value uninitialized. Maybe we should delete it
> to ensure that
rnk added inline comments.
Comment at: include/clang/AST/VTableBuilder.h:54
@@ -53,3 +53,3 @@
- VTableComponent() { }
+ VTableComponent() = default;
Is this ctor used? It leaves Value uninitialized. Maybe we should delete it to
ensure that it isn't called,
rsmith added a comment.
This change now disables the move constructor and move assignment. I think just
removing the comment is better.
http://reviews.llvm.org/D11928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Prazek updated this revision to Diff 31863.
http://reviews.llvm.org/D11928
Files:
include/clang/AST/VTableBuilder.h
Index: include/clang/AST/VTableBuilder.h
===
--- include/clang/AST/VTableBuilder.h
+++ include/clang/AST/VTableBui
rnk added a comment.
I added this code before C++11 migration. I wanted to explicitly default the
copy ctor to document that it's a value type, rather than defaulting it
implicitly. You can nuke both comments and uncomment the definition.
http://reviews.llvm.org/D11928
_
rsmith added a comment.
Reid, do you remember what this FIXME was for? (Added in r198462.)
http://reviews.llvm.org/D11928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
