Re: [PATCH] D11896: [clang-cl] Add support for CL and _CL_ environment variables

2015-08-10 Thread David Majnemer via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL244473: [clang-cl] Add support for CL and _CL_ environment variables (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D11896?vs=31640&id=31695#toc Repository: rL LLVM http://

Re: [PATCH] D11896: [clang-cl] Add support for CL and _CL_ environment variables

2015-08-10 Thread Reid Kleckner via cfe-commits
rnk added inline comments. Comment at: tools/driver/driver.cpp:451 @@ +450,3 @@ + if (Tokenizer == &llvm::cl::TokenizeWindowsCommandLine) { +// The first instance of '#' should be replaced with '='. +auto AdjustOpt = [] (const char *Opt) { I'd also rather

Re: [PATCH] D11896: [clang-cl] Add support for CL and _CL_ environment variables

2015-08-10 Thread Hans Wennborg via cfe-commits
hans added a subscriber: hans. hans accepted this revision. hans added a reviewer: hans. hans added a comment. Out of curiosity, did you run in to something that relies on this in the wild? Comment at: tools/driver/driver.cpp:452 @@ +451,3 @@ +// The first instance of '#' sh

Re: [PATCH] D11896: [clang-cl] Add support for CL and _CL_ environment variables

2015-08-10 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: tools/driver/driver.cpp:464-466 @@ +463,5 @@ + PrependedOpts); + // Insert right after the program name to prepend to