Re: [PATCH] D106535: [clangd] Use CommandMangler in TestTU

2021-07-23 Thread Kadir Çetinkaya via cfe-commits
Can you provide a reproducer or build bot failure for the crash Fangrui ? On Fri, Jul 23, 2021 at 6:50 PM Fangrui Song via Phabricator < revi...@reviews.llvm.org> wrote: > MaskRay added a comment. > > `[clangd] Get rid of arg adjusters in CommandMangler` can crash > `BuildCompilerInvocation.Drops

Re: [PATCH] D106535: [clangd] Use CommandMangler in TestTU

2021-07-22 Thread Kadir Çetinkaya via cfe-commits
yes that's right. On Thu, Jul 22, 2021 at 12:20 PM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added a comment. > > I guess this is technically untested, but will be covered after D106527 < > https://reviews.llvm.org/D106527>? > > > Repository: > rG LLVM Github Mon