Re: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-24 Thread Rainer Orth via cfe-commits
Hi Douglas, > I figured it out. Because you are using printf, you no longer need the > '\\c'. If I use the following RUN line, the test passes on both > Windows/linux (I don't have solaris to test unfortunately): > > // RUN: printf '%%s\n' '/I%S\Inputs\cl-response-file\ /DFOO=2' > %t.rsp I've now

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread via cfe-commits
@lists.llvm.org Subject: Re: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c Hi Douglas, > I figured it out. Because you are using printf, you no longer need the > '\\c'. If I use the following RUN line, the test passes on both > Windows/linux (I don't have solar

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread via cfe-commits
DFOO=2' > %t.rsp I can submit this patch for you if you would like. Douglas Yung -Original Message- From: Rainer Orth Sent: Friday, June 21, 2019 7:02 To: Yung, Douglas Cc: r...@gcc.gnu.org; cfe-commits@lists.llvm.org Subject: Re: r363985 - [test][Driver] Fix Clang :: Driver/c

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread via cfe-commits
the 4 backslashes. I think this could probably be fixed by just using a regex to match 1 or more backslashes? Douglas Yung -Original Message- From: Rainer Orth Sent: Friday, June 21, 2019 7:02 To: Yung, Douglas Cc: r...@gcc.gnu.org; cfe-commits@lists.llvm.org Subject: Re: r363985 -

Re: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread Rainer Orth via cfe-commits
Hi Douglas, > Your change appears to have broken the one platform you didn't test, Windows. > :) sorry about that. Unfortunately, I know next to nothing about Windows and don't have access to any system to test. That said... > Script: > -- > : 'RUN: at line 7'; printf > '/IC:\ps4-buildslave2\

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread via cfe-commits
Hi Rainer, Your change appears to have broken the one platform you didn't test, Windows. :) http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26514/steps/test/logs/stdio FAIL: Clang :: Driver/cl-response-file.c (8601 of 50455) TEST 'Cl