Re: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-13 Thread Steven Wu via cfe-commits
e.com] > Sent: Friday, May 13, 2016 1:27 PM > To: Liu, Yaxun (Sam) > Cc: cfe-commits@lists.llvm.org > Subject: Re: r269431 - [OpenCL] Add supported OpenCL extensions to target > info. > > Hi Yaxun > > You seems missing some override keyword that triggers > -Winc

RE: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-13 Thread Liu, Yaxun (Sam) via cfe-commits
s.llvm.org Subject: Re: r269431 - [OpenCL] Add supported OpenCL extensions to target info. Hi Yaxun You seems missing some override keyword that triggers -Winconsistent-missing-override. See: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_build/24442/warnings8Result/new/

RE: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-13 Thread Liu, Yaxun (Sam) via cfe-commits
supported OpenCL extensions to target info. Hi Yaxun You seems missing some override keyword that triggers -Winconsistent-missing-override. See: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_build/24442/warnings8Result/new/ Here is a patch to fix them: diff --git a/lib/Basic

Re: r269431 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-13 Thread Steven Wu via cfe-commits
Hi Yaxun You seems missing some override keyword that triggers -Winconsistent-missing-override. See: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_build/24442/warnings8Result/new/ Here is a patch to fix them: diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp inde