Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

2015-12-24 Thread Sanjay Patel via cfe-commits
gt; > --paulr > > > > *From:* cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] *On > Behalf Of *Eric Christopher via cfe-commits > *Sent:* Sunday, November 29, 2015 2:21 PM > *To:* Simon Pilgrim; cfe-commits@lists.llvm.org > *Subject:* Re: r254262 - [X86][SSE2] A

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

2015-11-29 Thread Eric Christopher via cfe-commits
s not a guarantee but it certainly should help. --paulr *From:* cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] *On Behalf Of *Eric Christopher via cfe-commits *Sent:* Sunday, November 29, 2015 2:21 PM *To:* Simon Pilgrim; cfe-commits@lists.llvm.org *Subject:* Re: r254262 - [X86][SSE2]

RE: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

2015-11-29 Thread Robinson, Paul via cfe-commits
Resending because I forgot to explicitly CC the list AGAIN. :-P > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Simon Pilgrim via cfe-commits > Sent: Sunday, November 29, 2015 12:23 PM > To: cfe-commits@lists.llvm.org > Subject: r254262 -

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

2015-11-29 Thread Simon Pilgrim via cfe-commits
OK I’ll see what I can do to split the tests with a -O0/-fast-isel llc version. I understand the work is straightforward, as I said my fear is that by breaking the connection we end up with syncing issues with the backend testing for IR patterns that the frontend no longer generates, which is wh

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

2015-11-29 Thread Eric Christopher via cfe-commits
There's no reason a split set of tests would fail at doing this. You can test that the IR is what you expect and then that the backend tests it as well. It's very simple to do. On Sun, Nov 29, 2015, 2:08 PM Simon Pilgrim wrote: > So the problem we’re trying to solve is it make sure that in debug

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

2015-11-29 Thread Simon Pilgrim via cfe-commits
So the problem we’re trying to solve is it make sure that in debug builds, clang compiles c/c++ intrinsics in the headers down to assembly that is very close to the expected instruction. What we had before (testing c/c++ to IR results in clang/test/CodeGen and testing with llc on ‘similar' IR i

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

2015-11-29 Thread Eric Christopher via cfe-commits
This is amazing... And entirely the wrong place for the asm tests. :) Would you mind splitting this test case in two with an IR test for clang and an asm test for llvm? Thanks! On Sun, Nov 29, 2015, 12:25 PM Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon >