omas ; cfe-commits@lists.llvm.org; 'nd'
Subject: RE: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel
attributes
Hi,
What I mean is the spec of spir 1.2/2.0 has very clear example about how the
metadata should organized. But now with this patch, the result of spir
Yaxun (Sam) (yaxun@amd.com)
Cc: thomas.stell...@amd.com; cfe-commits@lists.llvm.org; nd
Subject: RE: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel
attributes
Hi Xiuli,
Could you please elaborate what do you think it broken exactly?
Because we haven't actually removed
ssage-
From: Yaxun Liu [mailto:yaxun@amd.com]
Sent: Wednesday, June 22, 2016 11:04 PM
To: yaxun@amd.com; xiuli...@outlook.com; anastasia.stul...@arm.com;
alexey.ba...@intel.com
Cc: thomas.stell...@amd.com; cfe-commits@lists.llvm.org
Subject: Re: [PATCH] D20979: [OpenCL] Use function met
@amd.com]
Sent: Wednesday, June 22, 2016 11:04 PM
To: yaxun@amd.com; xiuli...@outlook.com; anastasia.stul...@arm.com;
alexey.ba...@intel.com
Cc: thomas.stell...@amd.com; cfe-commits@lists.llvm.org
Subject: Re: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel
attributes
This
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273425: [OpenCL] Use function metadata to represent kernel
attributes (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D20979?vs=60545&id=61555#toc
Repository:
rL LLVM
http://r
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/kernel-attributes.cl:9
@@ -8,3 +10,1 @@
-// CHECK: opencl.kernels = !{[[MDNODE0:![0-9]+]], [[MDNODE3:![0-9]+]]}
-
bader wrote:
> AFAIK, this named metadata node were also useful for kernel functions
>
bader accepted this revision.
bader added a comment.
LGTM.
Comment at: test/CodeGenOpenCL/kernel-attributes.cl:9
@@ -8,3 +10,1 @@
-// CHECK: opencl.kernels = !{[[MDNODE0:![0-9]+]], [[MDNODE3:![0-9]+]]}
-
AFAIK, this named metadata node were also useful for ker
yaxunl added a comment.
Ping!
Alexey/Xiuli, are you OK with this change? Thanks.
http://reviews.llvm.org/D20979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D20979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
yaxunl added a comment.
I updated the patch to use function metadata only. Please review. Thanks.
http://reviews.llvm.org/D20979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl retitled this revision from "[OpenCL] Use function attribute/metadata to
represent kernel attributes" to "[OpenCL] Use function metadata to represent
kernel attributes".
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 60545.
http://reviews.llvm.org/D2097
11 matches
Mail list logo
