Anastasia added a comment.
LGTM! Looks much cleaner now. Please, add me to related reviews later on.
Thanks!
http://reviews.llvm.org/D20681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
yaxunl updated this revision to Diff 60105.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Refactor to eliminate lambda function argument.
http://reviews.llvm.org/D20681
Files:
include/clang/CodeGen/BackendUtil.h
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CodeGenAction.cpp
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
> > We have prelinking passes in amdgpu backend but it requires the llvm change
> > to be committed first. We can add a test for this after that.
>
>
> Sure. Could you subscribe me to the relevant backend reviews if possible
>
Anastasia added a comment.
In http://reviews.llvm.org/D20681#450073, @yaxunl wrote:
> In http://reviews.llvm.org/D20681#448443, @Anastasia wrote:
>
> > Do you think we could add any test for this change?
>
>
> We have prelinking passes in amdgpu backend but it requires the llvm change
> to be co
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
In http://reviews.llvm.org/D20681#448443, @Anastasia wrote:
> Do you think we could add any test for this change?
We have prelinking passes in amdgpu backend but it requires the llvm change to
be committed first. We can add a tes
Anastasia added a comment.
Do you think we could add any test for this change?
Comment at: lib/CodeGen/BackendUtil.cpp:657
@@ -627,2 +656,3 @@
+
bool EmitAssemblyHelper::AddEmitPasses(BackendAction Action,
Remove the empty line please
Commen
To: reviews+d20681+public+7364792746786...@reviews.llvm.org;
rich...@metafoo.co.uk; anastasia.stul...@arm.com
Cc: Stellard, Thomas ; cfe-commits@lists.llvm.org;
Sumner, Brian
Subject: RE: [PATCH] D20681: Add target-specific pre-linking passes to Clang
+ Brian
-Original Message-
From
+ Brian
-Original Message-
From: Tom Stellard [mailto:thomas.stell...@amd.com]
Sent: Thursday, May 26, 2016 11:11 AM
To: Liu, Yaxun (Sam) ; rich...@metafoo.co.uk;
anastasia.stul...@arm.com
Cc: Stellard, Thomas ; cfe-commits@lists.llvm.org
Subject: Re: [PATCH] D20681: Add target-specific
tstellarAMD added a comment.
Can you give some examples of what pre-link passes may be required?
http://reviews.llvm.org/D20681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
