EricWF closed this revision.
EricWF added a comment.
r268284.
In http://reviews.llvm.org/D19625#418697, @STL_MSFT wrote:
> No problem! With these changes, my test runs are currently clean wrt "warning
> C4100: unreferenced formal parameter" and "warning C4101: unreferenced local
> variable", b
STL_MSFT added a comment.
No problem! With these changes, my test runs are currently clean wrt "warning
C4100: unreferenced formal parameter" and "warning C4101: unreferenced local
variable", but note that (1) Clang may emit unused-variable warnings in
somewhat different situations, and (2) I'v
EricWF added a comment.
Our test harness has a switch to enable warnings. I would be happy to set up a
bot in that configuration. It would probably be easier than setting up one that
uses MSVC.
Currently that mode disables the unused variable warnings but if/when STL
cleans all of those we can
[STL]
> When my work is finished (currently 3132 tests are passing out of 4541), I
> expect that
> we'll start running libcxx's tests in our automation, which will detect
> regressions rapidly and reliably.
[David Blaikie]
> It'd be great to have this sort of stuff upstream (in a public facing
On Fri, Apr 29, 2016 at 4:59 PM, Stephan T. Lavavej <
s...@exchange.microsoft.com> wrote:
> [David Blaikie]
> > Unused-variable seems pretty low value.
>
> Yeah, but it still has the potential to detect mistakes (e.g. typos, or
> code you intended to write but forgot about).
>
> I figured I'd subm
[David Blaikie]
> Unused-variable seems pretty low value.
Yeah, but it still has the potential to detect mistakes (e.g. typos, or code
you intended to write but forgot about).
I figured I'd submit a patch, since there weren't actually that many
occurrences, and they were all easy to silence in
On Fri, Apr 29, 2016 at 4:34 PM, Stephan T. Lavavej via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> STL_MSFT marked 2 inline comments as done.
> STL_MSFT added a comment.
>
> What I'm doing is running libcxx's tests against MSVC's compiler and
> libraries. I could aggressively suppress warn
STL_MSFT marked 2 inline comments as done.
STL_MSFT added a comment.
What I'm doing is running libcxx's tests against MSVC's compiler and libraries.
I could aggressively suppress warnings (and indeed I'm doing that for the
noisiest, lowest-value warnings), but instead I'm building the tests with
I'm not sure why we'd want to compile the test suite with -Wunused-variable
(& even if we did, I imagine Clang's doesn't fire here because the
variables are used, just in non-evaluated contexts?)? Is there a benefit to
it being clean of unused-variable warnings? (in Clang's test case we just
aggres
STL_MSFT updated the summary for this revision.
STL_MSFT updated this revision to Diff 55683.
STL_MSFT added a comment.
This moves "str" as requested. It also adds void casts to another file, and
removes an unused argc/argv pair.
http://reviews.llvm.org/D19625
Files:
test/std/depr/depr.c.hea
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
One inline change requested.
Comment at:
test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp:24421
STL_MSFT added a comment.
Are there any issues with these changes? I tried to follow the existing
practice for void-casting, including the comment (although the comments varied).
http://reviews.llvm.org/D19625
___
cfe-commits mailing list
cfe-commi
12 matches
Mail list logo
