; Adrian Prantl; cfe-commits
Subject: Re: [PATCH] D19567: PR21823: 'nodebug' attribute on global/static
variables
ping
On Mon, May 2, 2016 at 11:51 AM, David Blaikie via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
dblaikie added a comment.
In http://reviews.llvm.o
ping
On Mon, May 2, 2016 at 11:51 AM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> dblaikie added a comment.
>
> In http://reviews.llvm.org/D19567#414906, @probinson wrote:
>
> > Huh. There are strange interactions here, which makes me even more
> nervous about testing fe
dblaikie added a comment.
In http://reviews.llvm.org/D19567#414906, @probinson wrote:
> Huh. There are strange interactions here, which makes me even more nervous
> about testing fewer cases.
Generally this sort of thing makes me more interested in testing fewer cases so
we can see/make sure
1ee0c82c0824b...@reviews.llvm.org; Robinson, Paul
Cc: Aaron Ballman; Adrian Prantl; cfe-commits
Subject: Re: [PATCH] D19567: PR21823: 'nodebug' attribute on global/static
variables
On Wed, Apr 27, 2016 at 3:24 PM, Paul Robinson via cfe-commits
mailto:cfe-commits@lists.llvm.org>> w
On Wed, Apr 27, 2016 at 3:24 PM, Paul Robinson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> probinson added a comment.
>
> In http://reviews.llvm.org/D19567#413997, @dblaikie wrote:
>
> > For 3 code paths (that seem fairly independent from one another) I'd
> only really expect to see 3 v
probinson added a comment.
In http://reviews.llvm.org/D19567#413997, @dblaikie wrote:
> For 3 code paths (that seem fairly independent from one another) I'd only
> really expect to see 3 variables in the test - one to exercise each codepath.
> What's the reason for the larger set of test cases?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267746: PR21823: 'nodebug' attribute on global/static
variables. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D19567?vs=55116&id=55260#toc
Repository:
rL LLVM
http://rev
dblaikie added a comment.
For 3 code paths (that seem fairly independent from one another) I'd only
really expect to see 3 variables in the test - one to exercise each codepath.
What's the reason for the larger set of test cases?
Then it might be simpler just to include 6 variables, one of each
aprantl added a comment.
Ah great, I didn't know that!
http://reviews.llvm.org/D19567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added inline comments.
Comment at: include/clang/Basic/Attr.td:976
@@ -975,3 +975,3 @@
let Spellings = [GCC<"nodebug">];
- let Documentation = [Undocumented];
+ let Documentation = [NoDebugDocs];
}
aaron.ballman wrote:
> This isn't your problem to
aprantl added a comment.
Debug info changes otherwise look good to me.
Comment at: test/CodeGenCXX/debug-info-nodebug.cpp:17
@@ +16,3 @@
+// YESINFO-DAG: !DIGlobalVariable(name: "global_int_def"
+// NOINFO-NOT: !DIGlobalVariable(name: "global_int_def"
+
I don't
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM on the attribute part. Someone else should pipe up if the debug info part
look
12 matches
Mail list logo
