alexfh added inline comments.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:452
+ if (FoundErrors) {
+ return 1;
Failed tests reminded me of the -fix-errors flag.
I suppose, clang-tidy should not return an error code, when all errors it
noticed, contain
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
This patch breaks a number of tests. Please run the tests and fix the failures.
https://reviews.llvm.org/D39105
___
cfe-commits mailing
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good! Thank you!
https://reviews.llvm.org/D39105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
antoyo created this revision.
Update clang-tidy to return 1 when there's an error.
https://reviews.llvm.org/D39105
Files:
clang-tidy/tool/ClangTidyMain.cpp
Index: clang-tidy/tool/ClangTidyMain.cpp
===
--- clang-tidy/tool/ClangT
The patch was lost. Could you re-attach it or even better upload to
reviews.llvm.org as described in http://llvm.org/docs/Phabricator.html?
Please make sure the patch applies cleanly to the current HEAD.
Thanks!
On Tue, Oct 17, 2017 at 9:10 PM, Friedman, Eli
wrote:
> Sometimes people just lose
Sometimes people just lose track; "pinging" is normal (see
http://llvm.org/docs/DeveloperPolicy.html#code-reviews). And sometimes
it's helpful to CC reviewers in the area; adding Alexander Kornienko.
-Eli
On 10/17/2017 12:03 PM, Antoni Boucher wrote:
Since the patch was redirected to the rig
Since the patch was redirected to the right mailing list and the subject
was edited, I believe everything is okay, now?
Is there any news?
Thanks.
On Thu, Sep 28, 2017 at 06:56:57PM +, Friedman, Eli wrote:
When you're submitting a patch, please make sure you're sending
it to the right list,
When you're submitting a patch, please make sure you're sending it to
the right list, and the "subject" line actually describes what the patch
changes; otherwise, reviewers won't notice the patch. Optionally, you
can submit a patch using Phabricator, a tool which which makes patch
reviews a li
