Re: PATCH: re-enable OpenCL extensions

2017-01-20 Thread Kalle Raiskila via cfe-commits
On 19.01.2017 23:43, Liu, Yaxun (Sam) wrote: I think the supported extensions for a target should be as accurate as possible, for it to be useful. Setting all extensions to be supported on all targets will defeat its purpose. I agree on the first part, but arrive at the exact opposite result

RE: PATCH: re-enable OpenCL extensions

2017-01-19 Thread Liu, Yaxun (Sam) via cfe-commits
different targets based on that. Sam -Original Message- From: Anastasia Stulova [mailto:anastasia.stul...@arm.com] Sent: Thursday, January 19, 2017 12:31 PM To: Kalle Raiskila Cc: cfe-commits@lists.llvm.org; Liu, Yaxun (Sam) ; nd Subject: RE: PATCH: re-enable OpenCL extensions As me

RE: PATCH: re-enable OpenCL extensions

2017-01-19 Thread Anastasia Stulova via cfe-commits
lto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Kalle Raiskila via cfe-commits Sent: 19 January 2017 08:03 To: cfe-commits@lists.llvm.org Subject: PATCH: re-enable OpenCL extensions Hi, I noticed a change from clang 3.8 to 3.9, that it disabled all OpenCL extension pragmas per default. This br

PATCH: re-enable OpenCL extensions

2017-01-19 Thread Kalle Raiskila via cfe-commits
Hi, I noticed a change from clang 3.8 to 3.9, that it disabled all OpenCL extension pragmas per default. This broke pocl on e.g. ARM for LLVM 3.9 (https://github.com/pocl/pocl/issues/409). Example: $ echo "#pragma OPENCL EXTENSION cl_khr_icd: enable" > hello.cl $ clang -emit-llvm -x cl -o tmp