Re: PATCH: Provide the compile commands of the JSON database in consistent order

2015-09-22 Thread Argyrios Kyrtzidis via cfe-commits
In r248292, the added unit test fails without the changes. > On Sep 18, 2015, at 5:49 PM, Manuel Klimek via cfe-commits > wrote: > > LG in general; I think if we like the order to be deterministic we should try > to come up with a unit test so nobody regresses this in the future. > > On Fri,

Re: PATCH: Provide the compile commands of the JSON database in consistent order

2015-09-18 Thread Manuel Klimek via cfe-commits
LG in general; I think if we like the order to be deterministic we should try to come up with a unit test so nobody regresses this in the future. On Fri, Sep 18, 2015 at 4:44 PM Argyrios Kyrtzidis wrote: > Hi, > > I have found it useful for the getAllCompileCommands() to return the > commands in

PATCH: Provide the compile commands of the JSON database in consistent order

2015-09-18 Thread Argyrios Kyrtzidis via cfe-commits
Hi, I have found it useful for the getAllCompileCommands() to return the commands in the order that they were provided in the JSON file. This is useful for debugging of issues and reduction of test cases. For example, an issue may show up due to the order that some commands were processed. It is