RE: Missing definition of a template virtual function

2016-06-06 Thread Srivastava, Sunil via cfe-commits
Hi Richard, Thanks for you analysis. I have some follow up questions though: First, either of these two suggestions below should fix the bug, though it may be better to do both. Right ? Then, approach (2) has a cost. It will prevent devirtualizations of calls which could get defined elsewhere.

Re: Missing definition of a template virtual function

2016-06-05 Thread Richard Smith via cfe-commits
On Sun, Jun 5, 2016 at 10:27 PM, Srivastava, Sunil < sunil.srivast...@sony.com> wrote: > Hi Richard, > > > > Thanks for you analysis. I have some follow up questions though: > > > First, either of these two suggestions below should fix the bug, though it > may be better to do both. Right ? > Eith

Re: Missing definition of a template virtual function

2016-05-27 Thread Richard Smith via cfe-commits
On Fri, May 27, 2016 at 1:03 PM, Srivastava, Sunil via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, > > > > I want to discuss the issue in PR27895, > >https://llvm.org/bugs/show_bug.cgi?id=27895 > > > > But I will give a slightly different example for this discussion. > > > > The

Missing definition of a template virtual function

2016-05-27 Thread Srivastava, Sunil via cfe-commits
Hi, I want to discuss the issue in PR27895, https://llvm.org/bugs/show_bug.cgi?id=27895 But I will give a slightly different example for this discussion. The issue can be demonstrated by this standalone code. Should this example link successfully? -