On 16/03/16 03:22, Richard Smith wrote:
Please restrict this to the case where the function template is a
friend (check D->getFriendObjectKind()). Otherwise, this looks good to
me. Thanks!
Done and committed in r263634.
Thanks!
On Mon, Mar 7, 2016 at 2:23 AM, Vassil Vassilev wrote:
ping...
Please restrict this to the case where the function template is a
friend (check D->getFriendObjectKind()). Otherwise, this looks good to
me. Thanks!
On Mon, Mar 7, 2016 at 2:23 AM, Vassil Vassilev wrote:
> ping...
>
> On 22/02/16 21:51, Vassil Vassilev wrote:
>>
>> On 02/02/16 02:52, Richard Smit
ping...
On 22/02/16 21:51, Vassil Vassilev wrote:
On 02/02/16 02:52, Richard Smith via cfe-commits wrote:
On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev
wrote:
Would this patch be more reasonable? It follows what
RegisterTemplateSpecialization (introduced in r245779) does. AFAICT
this
adds
/Serialization/ASTWriter.cpp | 7 +--
test/Modules/Inputs/PR24954/A.h | 10 ++
test/Modules/Inputs/PR24954/B.h | 30 ++++
test/Modules/Inputs/PR24954/module.modulemap | 9 +
test/Modules/pr24954.cpp
On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev wrote:
> Would this patch be more reasonable? It follows what
> RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this
> adds an update record far less often.
It's still adding redundant update records. We'll write the
appropriate
bugs/show_bug.cgi?id=24954
---
include/clang/Serialization/ASTWriter.h | 3 +++
lib/Serialization/ASTWriter.cpp | 20 +++
test/Modules/Inputs/PR24954/A.h | 10 ++
test/Modules/Inputs/PR24954/B.h | 30 +++++++++
Forwarding to cfe-commits
Forwarded Message
Subject:[modules] PR24954
Date: Thu, 8 Oct 2015 15:53:55 +0200
From: Vassil Vassilev
To: Richard Smith , cfe-...@cs.uiuc.edu
CC: Ben Langmuir
Hi Richard,
I started working on https://llvm.org/bugs
