https://github.com/felipepiovezan requested changes to this pull request.
Hi @jeevanghimire, thank you for the PR! I believe the original issue was not
about changing LLVM test inputs, but rather about changing clang-tidy to warn
about this kind of patterns.
Please see my rationale in a previo
@@ -56,10 +56,10 @@ namespace Foo = A::B; // namespace alias
using Foo::myfunc; // using declaration
-using namespace Foo;// using directive
+//removing namespace foo; for quality naming
jeevanghimire wrote:
but it can create confusion if we just
@@ -56,10 +56,10 @@ namespace Foo = A::B; // namespace alias
using Foo::myfunc; // using declaration
-using namespace Foo;// using directive
+//removing namespace foo; for quality naming
Michael137 wrote:
The `using` directive was used here to ma
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 58bdef2be75263a9b6bf93faf3baccc76e31e082
c137cd0ba81f82dbca2feb01bb8d088e42f0c524 --
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-lldb
Author: Jeevan Ghimire (jeevanghimire)
Changes
removing using namespace std;
and assigning the fully qualified name for better naming in codebase
---
Full diff: https://github.com/llvm/llvm-project/pull/74814.diff
2 F
https://github.com/jeevanghimire created
https://github.com/llvm/llvm-project/pull/74814
removing using namespace std;
and assigning the fully qualified name for better naming in codebase
>From c137cd0ba81f82dbca2feb01bb8d088e42f0c524 Mon Sep 17 00:00:00 2001
From: Jeevan Ghimire
Date: Fri,
