https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
georgthegreat wrote:
I think this is how my clang-format-16 auto-formatted it.
I have applied the formatting from the check, it is green now.
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
https://github.com/georgthegreat updated
https://github.com/llvm/llvm-project/pull/125412
>From 69307d52fc749c847da74e98624ce1c39f2fe2d9 Mon Sep 17 00:00:00 2001
From: Yuriy Chernyshov
Date: Sun, 2 Feb 2025 14:35:53 +0100
Subject: [PATCH 1/3] Silence -Wunused-parameter warnings in Unwind-wasm.c
https://github.com/georgthegreat updated
https://github.com/llvm/llvm-project/pull/125412
>From 69307d52fc749c847da74e98624ce1c39f2fe2d9 Mon Sep 17 00:00:00 2001
From: Yuriy Chernyshov
Date: Sun, 2 Feb 2025 14:35:53 +0100
Subject: [PATCH 1/3] Silence -Wunused-parameter warnings in Unwind-wasm.c
ldionne wrote:
Sure, but I am not certain why you added some newlines though.
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
georgthegreat wrote:
@ldionne, may we proceed with merging this?
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
georgthegreat wrote:
I applied @ldionne suggestions, I am fine with his approach.
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -102,8 +102,9 @@ _LIBUNWIND_EXPORT uintptr_t _Unwind_GetIP(struct
_Unwind_Context *context) {
}
/// Not used in Wasm.
-_LIBUNWIND_EXPORT void _Unwind_SetIP(struct _Unwind_Context *context,
- uintptr_t value) {}
+_LIBUNWIND_EXPORT void
+_
https://github.com/ldionne commented:
IMO this is reasonable but it's simpler to drop the parameter names in this
case, no need for `[[maybe_unused]]`.
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llv
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -116,7 +117,7 @@ _Unwind_GetLanguageSpecificData(struct _Unwind_Context
*context) {
/// Not used in Wasm.
_LIBUNWIND_EXPORT uintptr_t
-_Unwind_GetRegionStart(struct _Unwind_Context *context) {
+_Unwind_GetRegionStart([[maybe_unused]] struct _Unwind_Context *context) {
georgthegreat wrote:
@MaskRay, we build libunwind using our own build system with the clang default
set of warnings enabled.
There is already a couple of `[[maybe_unused]]` attributes in this library, so
I do not bring anything new:
```
(dflt) thegeorg@jakku:~/contrib/llvm/libunwind@main$ rg u
https://github.com/MaskRay requested changes to this pull request.
What's your build option?
llvm-project considers this warning low value and
llvm/cmake/modules/HandleLLVMOptions.cmake specifies -Wno-unused-parameter.
https://github.com/llvm/llvm-project/pull/125412
__
https://github.com/georgthegreat updated
https://github.com/llvm/llvm-project/pull/125412
>From 69307d52fc749c847da74e98624ce1c39f2fe2d9 Mon Sep 17 00:00:00 2001
From: Yuriy Chernyshov
Date: Sun, 2 Feb 2025 14:35:53 +0100
Subject: [PATCH] Silence -Wunused-parameter warnings in Unwind-wasm.c
--
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 642e84f0012b6e3a0e4f187bad5ee1775c3d623a
f3f30cca500f839a2e6647ea9acf0cea45a4e178 --e
llvmbot wrote:
@llvm/pr-subscribers-libunwind
Author: Yuriy Chernyshov (georgthegreat)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/125412.diff
1 Files Affected:
- (modified) libunwind/src/Unwind-wasm.c (+3-3)
``diff
diff --git a/libunwind/src/Unwind-was
https://github.com/georgthegreat created
https://github.com/llvm/llvm-project/pull/125412
None
>From f3f30cca500f839a2e6647ea9acf0cea45a4e178 Mon Sep 17 00:00:00 2001
From: Yuriy Chernyshov
Date: Sun, 2 Feb 2025 14:35:53 +0100
Subject: [PATCH] Silence -Wunused-parameter warnings in Unwind-wasm
17 matches
Mail list logo
