arichardson wrote:
> Gentle ping!
Sorry for the delay - I was busy with the RISC-V summit last week, hoping to
get to this PR later this week.
https://github.com/llvm/llvm-project/pull/67860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
ldionne wrote:
Gentle ping!
https://github.com/llvm/llvm-project/pull/67860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -43,6 +43,12 @@
#define LIBUNWIND_AVAIL
#endif
+#if defined(__SANITIZE_MEMORY__) ||
\
arichardson wrote:
Sounds good. In that case I'll update the PR when I'm back in the office next
Thursday.
https://github.
@@ -43,6 +43,12 @@
#define LIBUNWIND_AVAIL
#endif
+#if defined(__SANITIZE_MEMORY__) ||
\
MaskRay wrote:
GCC just doesn't support msan :)
https://github.com/llvm/llvm-project/pull/67860
___
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/67860
>From e39c568ba557fbca5d3ef17f3d4f4d74f15e8205 Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Fri, 29 Sep 2023 13:25:39 -0700
Subject: [PATCH 1/2] [libunwind] Fix running tests with MSan
In order to ru
@@ -43,6 +43,12 @@
#define LIBUNWIND_AVAIL
#endif
+#if defined(__SANITIZE_MEMORY__) ||
\
arichardson wrote:
Ah I assumed it was needed for GCC since it doesn't have __has_feature().
https://github.com/llvm/llvm-p
@@ -43,6 +43,12 @@
#define LIBUNWIND_AVAIL
#endif
+#if defined(__SANITIZE_MEMORY__) ||
\
MaskRay wrote:
`__SANITIZE_MEMORY__` is a macro defined by the Linux kernel and copied to
other projects.
We can drop it.
@@ -115,6 +121,18 @@ extern int unw_set_reg(unw_cursor_t *, unw_regnum_t,
unw_word_t) LIBUNWIND_AVAIL
extern int unw_set_fpreg(unw_cursor_t *, unw_regnum_t, unw_fpreg_t)
LIBUNWIND_AVAIL;
extern int unw_resume(unw_cursor_t *) LIBUNWIND_AVAIL;
+#ifdef LIBUNWIND_HAVE_MSAN
+//
@@ -115,6 +121,18 @@ extern int unw_set_reg(unw_cursor_t *, unw_regnum_t,
unw_word_t) LIBUNWIND_AVAIL
extern int unw_set_fpreg(unw_cursor_t *, unw_regnum_t, unw_fpreg_t)
LIBUNWIND_AVAIL;
extern int unw_resume(unw_cursor_t *) LIBUNWIND_AVAIL;
+#ifdef LIBUNWIND_HAVE_MSAN
+//
@@ -115,6 +121,18 @@ extern int unw_set_reg(unw_cursor_t *, unw_regnum_t,
unw_word_t) LIBUNWIND_AVAIL
extern int unw_set_fpreg(unw_cursor_t *, unw_regnum_t, unw_fpreg_t)
LIBUNWIND_AVAIL;
extern int unw_resume(unw_cursor_t *) LIBUNWIND_AVAIL;
+#ifdef LIBUNWIND_HAVE_MSAN
+//
@@ -115,6 +121,18 @@ extern int unw_set_reg(unw_cursor_t *, unw_regnum_t,
unw_word_t) LIBUNWIND_AVAIL
extern int unw_set_fpreg(unw_cursor_t *, unw_regnum_t, unw_fpreg_t)
LIBUNWIND_AVAIL;
extern int unw_resume(unw_cursor_t *) LIBUNWIND_AVAIL;
+#ifdef LIBUNWIND_HAVE_MSAN
+//
@@ -115,6 +121,18 @@ extern int unw_set_reg(unw_cursor_t *, unw_regnum_t,
unw_word_t) LIBUNWIND_AVAIL
extern int unw_set_fpreg(unw_cursor_t *, unw_regnum_t, unw_fpreg_t)
LIBUNWIND_AVAIL;
extern int unw_resume(unw_cursor_t *) LIBUNWIND_AVAIL;
+#ifdef LIBUNWIND_HAVE_MSAN
+//
@@ -621,6 +621,9 @@ inline bool LocalAddressSpace::findUnwindSections(pint_t
targetAddr,
}
// Try to find the unwind info using `dl_find_object`
dl_find_object findResult;
+ // _dl_find_object should fully initialize this struct, but we zero it to
+ // be safe in case
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/67860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/67860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/67860
>From e39c568ba557fbca5d3ef17f3d4f4d74f15e8205 Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Fri, 29 Sep 2023 13:25:39 -0700
Subject: [PATCH] [libunwind] Fix running tests with MSan
In order to run te
llvmbot wrote:
@llvm/pr-subscribers-libunwind
Changes
In order to run tests with MSan we have silence two false-positives:
First, we have to tell the runtime that __unw_getcontext actually populates the
buffer with initialized data.
Ideally we would call __msan_unpoison directly from __un
https://github.com/arichardson created
https://github.com/llvm/llvm-project/pull/67860
In order to run tests with MSan we have silence two false-positives:
First, we have to tell the runtime that __unw_getcontext actually populates the
buffer with initialized data.
Ideally we would call __msan
18 matches
Mail list logo
