[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

lenary wrote: @ArcaneNibble your contributions now definitely meet the threshold for commit access - please request it following the instructions in the Developer Policy: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access (also take a read of the rest of the policy to understan

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

https://github.com/kito-cheng closed https://github.com/llvm/llvm-project/pull/98855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

https://github.com/wangpc-pp approved this pull request. https://github.com/llvm/llvm-project/pull/98855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

ArcaneNibble wrote: I don't have write access, someone else needs to decide to merge https://github.com/llvm/llvm-project/pull/98855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

https://github.com/lenary approved this pull request. I'm happy with this from a RISC-V arch/abi point of view. https://github.com/llvm/llvm-project/pull/98855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

https://github.com/ArcaneNibble edited https://github.com/llvm/llvm-project/pull/98855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

@@ -1169,7 +1169,11 @@ DEFINE_LIBUNWIND_FUNCTION(_ZN9libunwind15Registers_riscv6jumptoEv) ILOAD x\i, (RISCV_ISIZE * \i)(a0) .endr // skip a0 for now +#if defined(__riscv_abi_rve) lenary wrote: > Okay, I apparently did not realize that you can explicit

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

https://github.com/ArcaneNibble updated https://github.com/llvm/llvm-project/pull/98855 >From c5435a4567c6b6bf46eb3fb5361e168811dc7be9 Mon Sep 17 00:00:00 2001 From: R Date: Mon, 15 Jul 2024 04:29:07 +0100 Subject: [PATCH] [RISCV] Allow libunwind to build for rv32e --- libunwind/src/UnwindReg

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

@@ -1169,7 +1169,11 @@ DEFINE_LIBUNWIND_FUNCTION(_ZN9libunwind15Registers_riscv6jumptoEv) ILOAD x\i, (RISCV_ISIZE * \i)(a0) .endr // skip a0 for now +#if defined(__riscv_abi_rve) ArcaneNibble wrote: Okay, I apparently did not realize that you can expl

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

@@ -1169,7 +1169,11 @@ DEFINE_LIBUNWIND_FUNCTION(_ZN9libunwind15Registers_riscv6jumptoEv) ILOAD x\i, (RISCV_ISIZE * \i)(a0) .endr // skip a0 for now +#if defined(__riscv_abi_rve) lenary wrote: > The non-e case seems to be saving/restoring all register

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

@@ -1169,7 +1169,11 @@ DEFINE_LIBUNWIND_FUNCTION(_ZN9libunwind15Registers_riscv6jumptoEv) ILOAD x\i, (RISCV_ISIZE * \i)(a0) .endr // skip a0 for now +#if defined(__riscv_abi_rve) ArcaneNibble wrote: In general, libunwind seems to be somewhat inconsist

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

@@ -1169,7 +1169,11 @@ DEFINE_LIBUNWIND_FUNCTION(_ZN9libunwind15Registers_riscv6jumptoEv) ILOAD x\i, (RISCV_ISIZE * \i)(a0) .endr // skip a0 for now +#if defined(__riscv_abi_rve) lenary wrote: I don't understand how the non-e version of this list rela

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

@@ -1169,7 +1169,11 @@ DEFINE_LIBUNWIND_FUNCTION(_ZN9libunwind15Registers_riscv6jumptoEv) ILOAD x\i, (RISCV_ISIZE * \i)(a0) .endr // skip a0 for now +#if defined(__riscv_abi_rve) ArcaneNibble wrote: I deliberately chose to base it on the ABI so that,

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

ArcaneNibble wrote: ping? https://github.com/llvm/llvm-project/pull/98855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

ArcaneNibble wrote: ping? is there someone with the necessary knowledge to review this? https://github.com/llvm/llvm-project/pull/98855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

https://github.com/ldionne commented: This seems reasonable to me, but I have basically no knowledge of risvc or the rv32e ABI so I'll let someone else stamp this. https://github.com/llvm/llvm-project/pull/98855 ___ cfe-commits mailing list cfe-commit

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

llvmbot wrote: @llvm/pr-subscribers-libunwind Author: R (ArcaneNibble) Changes Don't try to save x16-x31 when using rv32e ABI Note that I haven't actually tested yet whether or not unwinding actually works on rv32e, but the code as-is doesn't even build. --- Full diff: https://github.co

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

https://github.com/ArcaneNibble created https://github.com/llvm/llvm-project/pull/98855 Don't try to save x16-x31 when using rv32e ABI Note that I haven't actually tested yet whether or not unwinding actually works on rv32e, but the code as-is doesn't even build. >From ae5c879de7d0dca880adcbb