Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-02-01 Thread Hans Wennborg via cfe-commits
Merged this one in r293813. Cheers, Hans On Wed, Feb 1, 2017 at 1:16 PM, Renato Golin wrote: > Right, the other one was 292607 and has already been merged. Sorry for > the confusion. We just need to merge this one and we're done. > > --renato > > On 1 February 2017 at 21:14, Renato Golin wrote:

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-02-01 Thread Renato Golin via cfe-commits
Right, the other one was 292607 and has already been merged. Sorry for the confusion. We just need to merge this one and we're done. --renato On 1 February 2017 at 21:14, Renato Golin wrote: > On 1 February 2017 at 19:33, Hans Wennborg wrote: >> Also I'm confused, since I haven't seen anything

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-02-01 Thread Renato Golin via cfe-commits
On 1 February 2017 at 19:33, Hans Wennborg wrote: > Also I'm confused, since I haven't seen anything besides r292638 > mentioned. Are there other changes besides that up for merging? I think the other commits were back-ported by other means (other PRs). Regardless, this is an important commit th

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-02-01 Thread Hans Wennborg via cfe-commits
On Tue, Jan 31, 2017 at 11:40 AM, Renato Golin wrote: > On 31 January 2017 at 18:36, Hans Wennborg wrote: Can you attach all commits that need to be backported into a bug against PR31622? We should probably squash them all before merge. >>> >>> What's the status here? >> >> Pi

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-01-31 Thread Renato Golin via cfe-commits
On 31 January 2017 at 18:36, Hans Wennborg wrote: >>> Can you attach all commits that need to be backported into a bug >>> against PR31622? >>> >>> We should probably squash them all before merge. >> >> What's the status here? > > Ping? Hum, I think Eric did create the bug, but now I can't rememb

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-01-31 Thread Hans Wennborg via cfe-commits
On Thu, Jan 26, 2017 at 10:23 AM, Hans Wennborg wrote: > On Fri, Jan 20, 2017 at 1:52 PM, Renato Golin wrote: >> On 20 January 2017 at 19:46, Eric Fiselier wrote: >>> This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7. >>> We should merge this into 4.0 to help get `check

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-01-26 Thread Hans Wennborg via cfe-commits
On Fri, Jan 20, 2017 at 1:52 PM, Renato Golin wrote: > On 20 January 2017 at 19:46, Eric Fiselier wrote: >> This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7. >> We should merge this into 4.0 to help get `check-all` clean. > > Hi Eric, > > All good on my side, pass with

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-01-20 Thread Renato Golin via cfe-commits
On 20 January 2017 at 19:46, Eric Fiselier wrote: > This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7. > We should merge this into 4.0 to help get `check-all` clean. Hi Eric, All good on my side, pass with GCC 5.4 and 6.3. Can you attach all commits that need to be bac

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-01-20 Thread Eric Fiselier via cfe-commits
This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7. We should merge this into 4.0 to help get `check-all` clean. /Eric On Fri, Jan 20, 2017 at 12:34 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Fri Jan 20 13:34:19 2017 >

[libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

2017-01-20 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jan 20 13:34:19 2017 New Revision: 292638 URL: http://llvm.org/viewvc/llvm-project?rev=292638&view=rev Log: Fix catch_reference_nullptr.pass.cpp test for GCC. This test contained an implicit conversion from nullptr to bool. Clang warns about this but the test had supresse