Re: [libcxx] r337727 - [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-23 Thread Heejin Ahn via cfe-commits
Sorry, and thanks! On Mon, Jul 23, 2018 at 5:32 PM Alex L wrote: > The revert commit is r337782. > > On 23 July 2018 at 17:32, Alex L wrote: > >> Hi, >> >> I had to revert your commit as it caused a number of failures in our >> public and internal CI. >> When building compiler-rt on Darwin (sta

Re: [libcxx] r337727 - [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-23 Thread Alex L via cfe-commits
Hi, I had to revert your commit as it caused a number of failures in our public and internal CI. When building compiler-rt on Darwin (stage1), after this commit the build failed to build X-ray and libfuzzer because the libc++ headers were no longer found. The compiler-rt libraries were built using

Re: [libcxx] r337727 - [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-23 Thread Alex L via cfe-commits
The revert commit is r337782. On 23 July 2018 at 17:32, Alex L wrote: > Hi, > > I had to revert your commit as it caused a number of failures in our > public and internal CI. > When building compiler-rt on Darwin (stage1), after this commit the build > failed to build X-ray and libfuzzer because

[libcxx] r337727 - [CMake] Fix the setting of LIBCXX_HEADER_DIR

2018-07-23 Thread Heejin Ahn via cfe-commits
Author: aheejin Date: Mon Jul 23 11:58:12 2018 New Revision: 337727 URL: http://llvm.org/viewvc/llvm-project?rev=337727&view=rev Log: [CMake] Fix the setting of LIBCXX_HEADER_DIR Reviewers: phosek Subscribers: mgorny, christof, ldionne, cfe-commits Differential Revision: https://reviews.llvm.or