Re: [libcxx] r334477 - [CMake] Use common variable for all header targets NFC

2018-06-27 Thread Ahmed Bougacha via cfe-commits
On Tue, Jun 12, 2018 at 8:04 PM, Ahmed Bougacha wrote: > Well, that was wrong. There are more install-cxx-headers targets that > the cache distribution implicitly depends on. > > Is there a reason for your cxx-headers -> cxx_headers change? If > there is, should the other cxx-headers targets cha

Re: [libcxx] r334477 - [CMake] Use common variable for all header targets NFC

2018-06-12 Thread Ahmed Bougacha via cfe-commits
Well, that was wrong. There are more install-cxx-headers targets that the cache distribution implicitly depends on. Is there a reason for your cxx-headers -> cxx_headers change? If there is, should the other cxx-headers targets change as well? If not, can we revert it? I'll try to reproduce in

Re: [libcxx] r334477 - [CMake] Use common variable for all header targets NFC

2018-06-12 Thread Ahmed Bougacha via cfe-commits
Hey Petr, FYI: clang has cmake caches that listed cxx-headers as a dependency; I fixed that in: r334550 [CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename. -Ahmed On Mon, Jun 11, 2018 at 11:58 PM, Petr Hosek via cfe-commits wrote: > Author: phosek > Date: Mon Jun 11 23:58:06

[libcxx] r334477 - [CMake] Use common variable for all header targets NFC

2018-06-12 Thread Petr Hosek via cfe-commits
Author: phosek Date: Mon Jun 11 23:58:06 2018 New Revision: 334477 URL: http://llvm.org/viewvc/llvm-project?rev=334477&view=rev Log: [CMake] Use common variable for all header targets NFC This simplifies the handling of header targets. Modified: libcxx/trunk/cmake/Modules/HandleLibCXXABI.cma