Re: [libcxx] r333325 - Add nonnull; use it for atomics

2018-05-29 Thread JF Bastien via cfe-commits
Hi Marshall, I’ve been thinking about this, and I propose we proceed the following way: Add a new warning to clang, -Wnonnull-attribute (modulo name bikeshed), which is part of the nonnull group and on by default. That warning specifically controls warnings generated by usage of the nonnull att

Re: [libcxx] r333325 - Add nonnull; use it for atomics

2018-05-26 Thread JF Bastien via cfe-commits
> On May 26, 2018, at 12:36 PM, Marshall Clow wrote: > > > > On Fri, May 25, 2018 at 4:43 PM, JF Bastien via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: jfb > Date: Fri May 25 16:43:53 2018 > New Revision: 25 > > URL: http://llvm.org/viewvc/llvm-project?rev=25

Re: [libcxx] r333325 - Add nonnull; use it for atomics

2018-05-26 Thread Marshall Clow via cfe-commits
On Fri, May 25, 2018 at 4:43 PM, JF Bastien via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jfb > Date: Fri May 25 16:43:53 2018 > New Revision: 25 > > URL: http://llvm.org/viewvc/llvm-project?rev=25&view=rev > Log: > Add nonnull; use it for atomics > > JF - please revert th

[libcxx] r333325 - Add nonnull; use it for atomics

2018-05-25 Thread JF Bastien via cfe-commits
Author: jfb Date: Fri May 25 16:43:53 2018 New Revision: 25 URL: http://llvm.org/viewvc/llvm-project?rev=25&view=rev Log: Add nonnull; use it for atomics Summary: The atomic non-member functions accept pointers to std::atomic / std::atomic_flag as well as to the non-atomic value. These a