Re: [libcxx] r299385 - suppress GCC warning about noexcept functions changing mangling

2017-04-03 Thread Richard Smith via cfe-commits
Thanks, that makes sense, I forgot to check for noexcept function types in template arguments. (Though I think GCC's diagnostic is sort of wrong or at least missing the point in this case, which is that 't' will have a different type in C++17.) On 3 Apr 2017 1:33 pm, "Eric Fiselier" wrote: Here

Re: [libcxx] r299385 - suppress GCC warning about noexcept functions changing mangling

2017-04-03 Thread Eric Fiselier via cfe-commits
Here is a reduced version. void glibc_function() throw() {} template struct Test { Test() {} // expected-error {{mangled name for 'Test::Test()' will change in C++17}} ~Test() {} // expected-error {{mangled name for 'Test::~Test()' will change in C++17}} }; Test t; /Eric On Mon, Apr 3, 2

Re: [libcxx] r299385 - suppress GCC warning about noexcept functions changing mangling

2017-04-03 Thread Eric Fiselier via cfe-commits
I'll create a reduced reproducer, but it'll take some time because GCC is quite cryptic about the instantiation stack. if you want many instances within the libc++ build simply revert this commit and build with a new GCC. /Eric ___ cfe-commits mailing l

Re: [libcxx] r299385 - suppress GCC warning about noexcept functions changing mangling

2017-04-03 Thread Richard Smith via cfe-commits
On 3 April 2017 at 13:53, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Mon Apr 3 15:53:15 2017 > New Revision: 299385 > > URL: http://llvm.org/viewvc/llvm-project?rev=299385&view=rev > Log: > suppress GCC warning about noexcept functions changing man

[libcxx] r299385 - suppress GCC warning about noexcept functions changing mangling

2017-04-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Apr 3 15:53:15 2017 New Revision: 299385 URL: http://llvm.org/viewvc/llvm-project?rev=299385&view=rev Log: suppress GCC warning about noexcept functions changing mangling Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/utils/libcxx/test/config.py Modified: li