Re: [libcxx] r299236 - Use strong enums independently of -fobjc-arc

2017-03-31 Thread Eric Fiselier via cfe-commits
On Fri, Mar 31, 2017 at 4:17 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > Thanks. Unfortunately that's one of the ways we figured it out :(. > > The status quo, before this commit, was an ABI difference between > Objective-C++ (-fobjc-arc) and C++/Objective-C++ (-fno-objc-arc), wh

Re: [libcxx] r299236 - Use strong enums independently of -fobjc-arc

2017-03-31 Thread Duncan P. N. Exon Smith via cfe-commits
Thanks. Unfortunately that's one of the ways we figured it out :(. The status quo, before this commit, was an ABI difference between Objective-C++ (-fobjc-arc) and C++/Objective-C++ (-fno-objc-arc), which is... really bad. But rare enough I guess it took a couple of years to find. I suspect/h

Re: [libcxx] r299236 - Use strong enums independently of -fobjc-arc

2017-03-31 Thread Eric Fiselier via cfe-commits
This will be ABI breaking for Objective-C++ users. I'm not objecting to fixing the bogus configuration, but I just wanted to point it out. /Eric On Fri, Mar 31, 2017 at 11:39 AM, Duncan P. N. Exon Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dexonsmith > Date: Fri Mar 31

[libcxx] r299236 - Use strong enums independently of -fobjc-arc

2017-03-31 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Fri Mar 31 12:39:56 2017 New Revision: 299236 URL: http://llvm.org/viewvc/llvm-project?rev=299236&view=rev Log: Use strong enums independently of -fobjc-arc r145698 introduced _LIBCPP_HAS_NO_STRONG_ENUMS by copy-pasting the __has_feature check from objc_arc_weak/_LIBCPP_H