Re: [libcxx] r297553 - Change test coverage generation to use llvm-cov instead of gcov.

2017-03-13 Thread Eric Fiselier via cfe-commits
Hi Bruno, Thank you for the fix. I couldn't get to it today. I'll watch the sanitizer bots more carefully in future. On Mar 13, 2017 10:26 PM, "Bruno Cardoso Lopes" wrote: > Hi Eric, > > I fixed the build for darwin in r297703, let me know if you have any > comments. > > Thanks, > > On Mon, Mar

Re: [libcxx] r297553 - Change test coverage generation to use llvm-cov instead of gcov.

2017-03-13 Thread Bruno Cardoso Lopes via cfe-commits
Hi Eric, I fixed the build for darwin in r297703, let me know if you have any comments. Thanks, On Mon, Mar 13, 2017 at 3:04 PM, Bruno Cardoso Lopes wrote: > Hi Eric, > >> if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR >> @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER) >>

Re: [libcxx] r297553 - Change test coverage generation to use llvm-cov instead of gcov.

2017-03-13 Thread Bruno Cardoso Lopes via cfe-commits
Hi Eric, > if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR > @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER) > message(WARNING "LLVM_USE_SANITIZER=${LLVM_USE_SANITIZER} is not > supported on OS X") >endif() >if (LIBFILE) > -execute_process(COMMAND ${CMAKE_CXX_

[libcxx] r297553 - Change test coverage generation to use llvm-cov instead of gcov.

2017-03-10 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Mar 10 21:24:18 2017 New Revision: 297553 URL: http://llvm.org/viewvc/llvm-project?rev=297553&view=rev Log: Change test coverage generation to use llvm-cov instead of gcov. Clang doesn't produce gcov compatible coverage files. This causes lcov to break because it uses gco