Re: [libcxx] r289963 - [CMake] Put headers relative to clang

2016-12-19 Thread Chris Bieneman via cfe-commits
Sorry I didn't reply to this email over the weekend. I did push a fix in r290052. My weekend was just a bit nuts, so I didn't take the time to reply here. The bot went green after that fix. If there are other issues please let me know. -Chris > On Dec 16, 2016, at 5:58 PM, Evgenii Stepanov >

Re: [libcxx] r289963 - [CMake] Put headers relative to clang

2016-12-16 Thread Evgenii Stepanov via cfe-commits
FTR, buildbot logs: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/2585/steps/test%20tsan%20in%20debug%20compiler-rt%20build/logs/stdio External project cmake error log: CMake Error at include/CMakeLists.txt:15 (file): file COPY cannot make directory "/include/c++/v1

Re: [libcxx] r289963 - [CMake] Put headers relative to clang

2016-12-16 Thread Evgenii Stepanov via cfe-commits
Hi, this is using LLVM_BINARY_DIR when NOT LIBCXX_USING_INSTALLED_LLVM. HandleOutOfTreeLLVM.cmake defines LLVM_BINARY_DIR only when LIBCXX_USING_INSTALLED_LLVM. Is it supposed to come from the user cmake arguments? This broke sanitizer tests on Linux (check-tsan, check-msan). See add_custom_libc

[libcxx] r289963 - [CMake] Put headers relative to clang

2016-12-16 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Fri Dec 16 11:30:51 2016 New Revision: 289963 URL: http://llvm.org/viewvc/llvm-project?rev=289963&view=rev Log: [CMake] Put headers relative to clang When libcxx isn't building with an installed LLVM we copy the libcxx headers into the LLVM build directory so that a clang