Re: [libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

2016-07-01 Thread Richard Smith via cfe-commits
On Fri, Jul 1, 2016 at 4:37 PM, Eric Fiselier wrote: > The attribute is ignored unless it is placed on the in-class declaration > of the member. It has no effect when applied to the explicit definition. > Ugh, right, attributes added after the definition aren't well-treated. Seems reasonable to

Re: [libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

2016-07-01 Thread Eric Fiselier via cfe-commits
The attribute is ignored unless it is placed on the in-class declaration of the member. It has no effect when applied to the explicit definition. I would rather keep the workaround internal than make the change in the headers. On Fri, Jul 1, 2016 at 5:34 PM, Richard Smith wrote: > On Fri, Jul 1,

Re: [libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

2016-07-01 Thread Richard Smith via cfe-commits
On Fri, Jul 1, 2016 at 4:22 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Fri Jul 1 18:22:25 2016 > New Revision: 274403 > > URL: http://llvm.org/viewvc/llvm-project?rev=274403&view=rev > Log: > Work around ABI break caused by C++17 inline variabl

[libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

2016-07-01 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 1 18:22:25 2016 New Revision: 274403 URL: http://llvm.org/viewvc/llvm-project?rev=274403&view=rev Log: Work around ABI break caused by C++17 inline variables. Modified: libcxx/trunk/src/chrono.cpp Modified: libcxx/trunk/src/chrono.cpp URL: http://llvm.org/viewv