> Eric, Marshall, what do you think about using only /*...*/-style
comments in these headers, to handle the case where libc++ is somehow in
the include path for a C89 compilation?
I'm NOT OK with this in general. These are C++ standard library headers
that are written in C++. These headers should
Eric, Marshall: has there been any progress here?
On Wed, Jan 20, 2016 at 10:29 AM, Hans Wennborg wrote:
> /sub
>
> On Wed, Jan 20, 2016 at 4:45 AM, Nico Weber via cfe-commits
> wrote:
>> Eric, Marshall: another ping. This should be fixed on the 3.8 branch, so it
>> needs to be resolved soon.
>>
/sub
On Wed, Jan 20, 2016 at 4:45 AM, Nico Weber via cfe-commits
wrote:
> Eric, Marshall: another ping. This should be fixed on the 3.8 branch, so it
> needs to be resolved soon.
>
> On Jan 5, 2016 5:25 PM, "Nico Weber" wrote:
>>
>> On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
>> wrote:
>>>
>
Eric, Marshall: another ping. This should be fixed on the 3.8 branch, so it
needs to be resolved soon.
On Jan 5, 2016 5:25 PM, "Nico Weber" wrote:
> On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
> wrote:
>
>> On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote:
>>
>>> One problem with this patch
On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
wrote:
> On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote:
>
>> One problem with this patch: stdio.h can be used in .c files, and when
>> building .c files with -gnu99 -pedantic,
>>
>
> Do you mean -std=gnu89?
>
>
>> clang will complain about // co
On Thu, Dec 31, 2015 at 10:52 AM, Nico Weber wrote:
> On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
> wrote:
>
>> On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote:
>>
>>> One problem with this patch: stdio.h can be used in .c files, and when
>>> building .c files with -gnu99 -pedantic,
>>>
>>
On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
wrote:
> On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote:
>
>> One problem with this patch: stdio.h can be used in .c files, and when
>> building .c files with -gnu99 -pedantic,
>>
>
> Do you mean -std=gnu89?
>
Sorry, I meant -std=gnu99 -pedantic
On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote:
> One problem with this patch: stdio.h can be used in .c files, and when
> building .c files with -gnu99 -pedantic,
>
Do you mean -std=gnu89?
> clang will complain about // comments. Not only does this stdio.h have //
> comments, it also pulls
One problem with this patch: stdio.h can be used in .c files, and when
building .c files with -gnu99 -pedantic, clang will complain about //
comments. Not only does this stdio.h have // comments, it also pulls in
some libc++ headers (__config) that have // comments as well. I suppose all
the commen
On Tue, Oct 13, 2015 at 3:26 PM, Eric Fiselier wrote:
> This change LGTM. Let's hold off on the using "_Static_assert" until we
> understand how that would work with "-pedantic" when the macro is expanded
> in user code.
>
Committed as r250247, thanks.
> /Eric
>
> On Tue, Oct 13, 2015 at 4:19
This change LGTM. Let's hold off on the using "_Static_assert" until we
understand how that would work with "-pedantic" when the macro is expanded
in user code.
/Eric
On Tue, Oct 13, 2015 at 4:19 PM, Richard Smith
wrote:
> On Tue, Oct 13, 2015 at 2:12 PM, Eric Fiselier via cfe-commits <
> cfe-c
On Tue, Oct 13, 2015 at 2:12 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I would rather not do this if possible but I understand why we need to do
> it.
>
> Richard is there a cost associated with the 'extern "C++"' construct? or
> by forcing the compiler to switch mod
I would rather not do this if possible but I understand why we need to do
it.
Richard is there a cost associated with the 'extern "C++"' construct? or by
forcing the compiler to switch modes in general?
On Mon, Oct 12, 2015 at 12:27 PM, Richard Smith
wrote:
> On Mon, Oct 12, 2015 at 9:41 AM,
On Mon, Oct 12, 2015 at 9:41 AM, Steven Wu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard
>
> Your splitting seems causing problem when using extern "C". Here is a test
> case:
>
> $ cat test.cpp
> #ifdef __cplusplus
> extern "C" {
> #endif
> #include
> #ifdef __cplusplus
> }
>
Hi Richard
Your splitting seems causing problem when using extern "C". Here is a test case:
$ cat test.cpp
#ifdef __cplusplus
extern "C" {
#endif
#include
#ifdef __cplusplus
}
#endif
Error:
clang -fsyntax-only test.cpp
In file included from test.cpp:4:
In file included from /usr/bin/../includ
Author: rsmith
Date: Thu Oct 8 20:29:09 2015
New Revision: 249798
URL: http://llvm.org/viewvc/llvm-project?rev=249798&view=rev
Log:
Split out of .
As with , skip our custom header if __need_FILE or __need___FILE is
defined.
Added:
libcxx/trunk/include/stdio.h
- copied, changed from
16 matches
Mail list logo
