Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2016-02-09 Thread Richard Smith via cfe-commits
On Wed, Jan 20, 2016 at 12:48 AM, Eric Fiselier via cfe-commits wrote: > The direction and change LGTM. Feel free to commit once the change has some > tests. Thanks, I updated the existing tests to no longer XFAIL Apple systems with recent Clang and committed as r260337. > On Fri, Jan 8, 2016 at

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2016-01-20 Thread Eric Fiselier via cfe-commits
The direction and change LGTM. Feel free to commit once the change has some tests. On Fri, Jan 8, 2016 at 5:45 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > No one is waiting for me on this, are they? FWIW, this seems like > a good solution to me. I'll see what I can do internall

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2016-01-08 Thread Duncan P. N. Exon Smith via cfe-commits
No one is waiting for me on this, are they? FWIW, this seems like a good solution to me. I'll see what I can do internally (I filed a radar), but other platforms will likely need this anyway. > On 2016-Jan-08, at 16:06, Richard Smith wrote: > > Ping, is this OK to commit? > > On Thu, Dec 10,

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2016-01-08 Thread Richard Smith via cfe-commits
Ping, is this OK to commit? On Thu, Dec 10, 2015 at 3:32 PM, Richard Smith wrote: > On Thu, Dec 10, 2015 at 11:45 AM, Marshall Clow > wrote: > >> On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith >>> wrote: >>> Ping. >>> >> Sorry about that. >> Completely missed this in my email flood. >

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-12-11 Thread Richard Smith via cfe-commits
On Thu, Dec 10, 2015 at 5:24 PM, Duncan P. N. Exon Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On 2015-Dec-10, at 15:32, Richard Smith wrote: > > > > On Thu, Dec 10, 2015 at 11:45 AM, Marshall Clow > wrote: > > On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith > wrote: > > Ping.

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-12-10 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2015-Dec-10, at 15:32, Richard Smith wrote: > > On Thu, Dec 10, 2015 at 11:45 AM, Marshall Clow wrote: > On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith wrote: > Ping. > > Sorry about that. > Completely missed this in my email flood. > > This approach looks ok to me, but I wonder if it wo

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-12-10 Thread Howard Hinnant via cfe-commits
Fwiw, if you ever here me gripe about the C++ committee’s poor record of messing around in the C headers with detrimental effects, this is what I’m referring to. Yes, the C++ signatures are superior. No, this wasn’t a good thing to do. The C++ committee should not try to change or delete stuf

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-12-10 Thread Richard Smith via cfe-commits
On Thu, Dec 10, 2015 at 11:45 AM, Marshall Clow wrote: > On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith >> wrote: >> >>> Ping. >>> >> > Sorry about that. > Completely missed this in my email flood. > > This approach looks ok to me, but I wonder if it would be better to get > Apple to fix their iO

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-12-10 Thread Marshall Clow via cfe-commits
> > On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith > wrote: > >> Ping. >> > Sorry about that. Completely missed this in my email flood. This approach looks ok to me, but I wonder if it would be better to get Apple to fix their iOS C library instead. Are there other broken C libraries that we are

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-12-09 Thread Eric Fiselier via cfe-commits
Richard could you do me a favor and put this on phabricator? /Eric On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith wrote: > Ping. > > On Mon, Nov 23, 2015 at 6:55 PM, Richard Smith > wrote: > >> Ping. >> >> On Thu, Nov 5, 2015 at 6:32 PM, Richard Smith >> wrote: >> >>> Ping. >>> >>> On Thu, Oct

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-12-08 Thread Richard Smith via cfe-commits
Ping. On Mon, Nov 23, 2015 at 6:55 PM, Richard Smith wrote: > Ping. > > On Thu, Nov 5, 2015 at 6:32 PM, Richard Smith > wrote: > >> Ping. >> >> On Thu, Oct 29, 2015 at 5:21 PM, Richard Smith >> wrote: >> >>> Hi, >>> >>> The attached patch undoes the revert of r249929, and adds an extension >>>

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-11-23 Thread Richard Smith via cfe-commits
Ping. On Thu, Nov 5, 2015 at 6:32 PM, Richard Smith wrote: > Ping. > > On Thu, Oct 29, 2015 at 5:21 PM, Richard Smith > wrote: > >> Hi, >> >> The attached patch undoes the revert of r249929, and adds an extension to >> allow (and ) to work properly even in environments such >> as iOS where the

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-11-05 Thread Richard Smith via cfe-commits
Ping. On Thu, Oct 29, 2015 at 5:21 PM, Richard Smith wrote: > Hi, > > The attached patch undoes the revert of r249929, and adds an extension to > allow (and ) to work properly even in environments such > as iOS where the underlying libc does not provide C++'s const-correct > overloads of strchr

[libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-10-29 Thread Richard Smith via cfe-commits
Hi, The attached patch undoes the revert of r249929, and adds an extension to allow (and ) to work properly even in environments such as iOS where the underlying libc does not provide C++'s const-correct overloads of strchr and friends. This works as follows: * The macro _LIBCPP_PREFERRED_OVER