frasercrmck wrote:
> > Nixpkgs has no intention of moving away from standalone builds.
>
> I encourage you to acquire that intention. IMO libclc should not support the
> standalone build, and this should be version locked to the exact compiler
> commit. It's compiler data, not a real library
RossComputerGuy wrote:
> Yes, it should be built along with the core (but doesn't need to ship in the
> same package as the core).
Sounds good, I'll communicate with the other LLVM Nix maintainers and see if
this is a good idea to fully go ahead on.
https://github.com/llvm/llvm-project/pull/1
arsenm wrote:
> So it should be built along with the core of LLVM? Also, we package LLVM per
> version per subproject.
Yes, it should be built along with the core (but doesn't need to ship in the
same package as the core).
https://github.com/llvm/llvm-project/pull/105969
__
RossComputerGuy wrote:
> IMO libclc should not support the standalone build, and this should be
> version locked to the exact compiler commit.
So it should be built along with the core of LLVM? Also, we package LLVM per
version per subproject.
> could this be avoided by changing the Nixpkgs b
hvdijk wrote:
> > Apologies, but I'm having a bit of trouble understanding the scenario that
> > this PR addresses.
>
> Nixpkgs adds the tools being used to `$PATH` so find program needs to use
> path.
This PR enables inadvertent errors on non-Nix systems though. When a specific
LLVM path is
arsenm wrote:
> Nixpkgs has no intention of moving away from standalone builds.
I encourage you to acquire that intention. IMO libclc should not support the
standalone build, and this should be version locked to the exact compiler
commit. It's compiler data, not a real library
https://github
RossComputerGuy wrote:
> Apologies, but I'm having a bit of trouble understanding the scenario that
> this PR addresses.
Nixpkgs adds the tools being used to `$PATH` so find program needs to use path.
https://github.com/llvm/llvm-project/pull/105969
RossComputerGuy wrote:
> The nix build should probably migrate to using the non-standalone build
Nixpkgs has no intention of moving away from standalone builds.
https://github.com/llvm/llvm-project/pull/105969
___
cfe-commits mailing list
cfe-commits@
hvdijk wrote:
Apologies, but I'm having a bit of trouble understanding the scenario that this
PR addresses. It looks like it's meant to handle the case where
`LLVM_TOOLS_BINARY_DIR` does not contain the LLVM binaries, is that right? In
that case, why can `LLVM_TOOLS_BINARY_DIR` not instead be
@@ -55,7 +55,7 @@ if( LIBCLC_STANDALONE_BUILD OR CMAKE_SOURCE_DIR STREQUAL
CMAKE_CURRENT_SOURCE_DI
# Import required tools
if( NOT EXISTS ${LIBCLC_CUSTOM_LLVM_TOOLS_BINARY_DIR} )
foreach( tool IN ITEMS clang llvm-as llvm-link opt )
- find_program( LLVM_TOOL_${tool
https://github.com/arsenm commented:
The nix build should probably migrate to using the non-standalone build
https://github.com/llvm/llvm-project/pull/105969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -55,7 +55,7 @@ if( LIBCLC_STANDALONE_BUILD OR CMAKE_SOURCE_DIR STREQUAL
CMAKE_CURRENT_SOURCE_DI
# Import required tools
if( NOT EXISTS ${LIBCLC_CUSTOM_LLVM_TOOLS_BINARY_DIR} )
foreach( tool IN ITEMS clang llvm-as llvm-link opt )
- find_program( LLVM_TOOL_${tool
https://github.com/arsenm edited
https://github.com/llvm/llvm-project/pull/105969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/105969
>From 056e0f9b7c7b788ad0d85a1479000fd1af4f98ce Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Sat, 24 Aug 2024 19:56:24 -0700
Subject: [PATCH] [libclc] use default paths with find_program when possibl
https://github.com/RossComputerGuy created
https://github.com/llvm/llvm-project/pull/105969
Patch pulled from https://github.com/NixOS/nixpkgs/pull/336465
This PR removes `NO_DEFAULT_PATH` where possible, the flag prevents Nix from
building libclc correctly.
>From e8b910246d0c7c3d9fff994f71c6
15 matches
Mail list logo
