[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Thankyou! So I think in CI we can not add any extra testing targets if libclc is included in the build. If you have some in future I'm happy to help enable them. https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits ma

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread Fraser Cormack via cfe-commits
frasercrmck wrote: > Also do you know if libclc has any tests worth running in CI? It doesn't have > a check-libclc so I'm not sure if that's because there's not much to run, or > running the tests requires a GPU or something else. > > Context is I've been looking at the pipeline we use for PR

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Also do you know if libclc has any tests worth running in CI? It doesn't have a check-libclc so I'm not sure if that's because there's not much to run, or running the tests requires a GPU or something else. Context is I've been looking at the pipeline we use for PRs and it

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/111369 >From a2dd2330359ecd3c04e01b6f9121481e6784014a Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 7 Oct 2024 12:29:41 + Subject: [PATCH 1/2] [libclc] Update build instructions in readme The conf

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck edited https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck commented: Thanks for doing this! I've had something like this at the back of my mind for a while. https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: One "andrew-podko" did request this get updated but that was in October 2020, so I expect they're not around anymore. https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111369 The configure Python script was removed by d6e0e6d255a7d54a3873b7a5d048eee00ef6bb6d / https://reviews.llvm.org/D69966. The readme was never updated with the cmake way to do it. I couldn't find any dedicat