[libclc] [libclc] Reduce include usage in OpenCL builtins (PR #146840)

2025-07-07 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/146840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Reduce include usage in OpenCL builtins (PR #146840)

2025-07-07 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/146840 >From eea3f1a2f5af14ac83c11bfb8da1d4be620d3078 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Thu, 3 Jul 2025 10:45:05 +0100 Subject: [PATCH 1/3] [libclc] Reduce include usage in OpenCL builtins This c

[libclc] [libclc] Reduce include usage in OpenCL builtins (PR #146840)

2025-07-06 Thread Wenju He via cfe-commits
https://github.com/wenju-he approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Reduce include usage in OpenCL builtins (PR #146840)

2025-07-04 Thread Fraser Cormack via cfe-commits
@@ -6,5 +6,12 @@ // //===--===// +#ifndef __CLC_OPENCL_OPENCL_INTEGER_ABS_H__ frasercrmck wrote: Ah it's because I copied it incorrectly from `__CLC_OPENCL_OPENCL_BASE_H__` which does need

[libclc] [libclc] Reduce include usage in OpenCL builtins (PR #146840)

2025-07-04 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/146840 >From 185d2fe1bc4a6237b7f42c27bb2c85fe77db3adb Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Thu, 3 Jul 2025 10:45:05 +0100 Subject: [PATCH 1/2] [libclc] Reduce include usage in OpenCL builtins This c

[libclc] [libclc] Reduce include usage in OpenCL builtins (PR #146840)

2025-07-04 Thread Fraser Cormack via cfe-commits
@@ -6,5 +6,12 @@ // //===--===// +#ifndef __CLC_OPENCL_OPENCL_INTEGER_ABS_H__ frasercrmck wrote: Oh, yes. And of course I'd copy/pasted the mistake to all files... https://github.com/llvm/l

[libclc] [libclc] Reduce include usage in OpenCL builtins (PR #146840)

2025-07-03 Thread Wenju He via cfe-commits
@@ -6,5 +6,12 @@ // //===--===// +#ifndef __CLC_OPENCL_OPENCL_INTEGER_ABS_H__ wenju-he wrote: ```suggestion #ifndef __CLC_OPENCL_INTEGER_ABS_H__ ``` one OPENCL should be sufficient, right?

[libclc] [libclc] Reduce include usage in OpenCL builtins (PR #146840)

2025-07-03 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/146840 This commit starts the process of reducing the amount of code included by OpenCL builtins, hopefully reducing build times in the process. It introduces a minimal OpenCL header - opencl-base.h - which includ