mgorny wrote:
Ah, it's just incorrect dependency. Filed #127315 to fix it.
https://github.com/llvm/llvm-project/pull/124727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny wrote:
I'm guessing that both `amdgcn` and `nvptx` targets now require
`clspv-generate_convert.cl`, but the targets for them are defined only when
`clspv` targets are enabled. No clue whether it means that the targets need to
be defined unconditionally, or `clc-convert.cl` skipped when
mgorny wrote:
The same failure also happens when SPIRV targets are disabled.
https://github.com/llvm/llvm-project/pull/124727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny wrote:
This change broke standalone libclc builds on Gentoo:
```
make -C
/tmp/portage/llvm-core/libclc-21.0.0_pre20250215/work/libclc_build/gentoo_common_config.cmake
-G Ninja -DCMAKE_INSTALL_PREFIX=/usr
-DLIBCLC_TARGETS_TO_BUILD=spirv-mesa3d-;spirv64-mesa3d-;r600--;amdgcn--;amdgcn-mes
https://github.com/frasercrmck closed
https://github.com/llvm/llvm-project/pull/124727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frasercrmck wrote:
I'm seeing several (82 out of 1045) conversions failures in the OpenCL-CTS.
It's in saturating conversions from floating-point types to integers, and in
regular float-to-float conversions. It isn't a result of this PR as they are
already present on `main`.
I will merge this
https://github.com/frasercrmck edited
https://github.com/llvm/llvm-project/pull/124727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/124727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frasercrmck updated
https://github.com/llvm/llvm-project/pull/124727
>From c0252c8da6fb4ae68699a7e6fc38ed7c643338e8 Mon Sep 17 00:00:00 2001
From: Fraser Cormack
Date: Mon, 11 Nov 2024 15:46:56 +
Subject: [PATCH 1/2] [libclc] Move conversion builtins to the CLC library
T
frasercrmck wrote:
> In fact my setup was busted. In the end it seems to work without change.
Thanks! Just for reference, is it just clspv's `check-spirv` you were running
to test? Anything else I should be aware of?
https://github.com/llvm/llvm-project/pull/124727
rjodinchr wrote:
clspv's `check-spirv` is what you want to test yes. But I was running within
Google infra to try directly using the OpenCL-CTS.
https://github.com/llvm/llvm-project/pull/124727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
rjodinchr wrote:
In fact my setup was busted. In the end it seems to work without change.
https://github.com/llvm/llvm-project/pull/124727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
frasercrmck wrote:
> I think for `clspv`, we would need to invert the condition to skip
> user-facing functions. By that I mean that `clspv` will need all the
> `convert_*` functions, and not the `__clc_convert_*_rte`. Then we will need
> to update `clspv` to support natively the function with
rjodinchr wrote:
I think for `clspv`, we would need to invert the condition to skip user-facing
functions. By that I mean that `clspv` will need all the `convert_*` functions,
and not the `__clc_convert_*_rte`. Then we will need to update `clspv` to
support natively the function with the `__cl
rjodinchr wrote:
This is not correct for `clspv`. It breaks everything and it feels like it
needs quite some work to fix. FYI, I'll be OOO from Feb 3 to Feb 21. Can it
wait that long? I'm not sure I'll have enough time to figure it out before the
end of the week.
https://github.com/llvm/llvm-
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/124727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frasercrmck updated
https://github.com/llvm/llvm-project/pull/124727
>From c87a1e7c0bd087241f4c9d16d9d115654e2bd85f Mon Sep 17 00:00:00 2001
From: Fraser Cormack
Date: Thu, 7 Nov 2024 12:40:56 +
Subject: [PATCH 1/6] [libclc] Move sign to the CLC builtins library
This pat
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
cfc8ef0ad8f70be22b44a8e1b56856795eb18282...4d5e786aa5c769e751d062662897a9882b607344
libcl
frasercrmck wrote:
CC @rjodinchr - are you able to test this PR out for your needs, by any chance?
It's quite intrusive so I'd like to be extra sure I haven't broken anything.
https://github.com/llvm/llvm-project/pull/124727
___
cfe-commits mailing li
https://github.com/frasercrmck created
https://github.com/llvm/llvm-project/pull/124727
This commit moves the implementations of conversion builtins to the CLC
library. It keeps the dichotomy of regular vs. clspv implementations of
the conversions. However, for the sake of a consistent interface
20 matches
Mail list logo
