https://github.com/frasercrmck closed
https://github.com/llvm/llvm-project/pull/109926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aaronpuchert approved this pull request.
That seems sensible to me.
The absolute path also makes sense because target properties could be requested
from a different directory, and then a relative path wouldn't work anymore.
https://github.com/llvm/llvm-project/pull/109926
__
https://github.com/frasercrmck edited
https://github.com/llvm/llvm-project/pull/109926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frasercrmck edited
https://github.com/llvm/llvm-project/pull/109926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frasercrmck updated
https://github.com/llvm/llvm-project/pull/109926
>From 567ea02fda22989a5af89746dbc5ed6eac0a43d9 Mon Sep 17 00:00:00 2001
From: Fraser Cormack
Date: Wed, 25 Sep 2024 09:18:10 +0100
Subject: [PATCH] [libclc] Fix installation w/ ENABLE_RUNTIME_SUBNORMAL
The
@@ -221,8 +221,10 @@ if( ENABLE_RUNTIME_SUBNORMAL )
TARGET ${file}
INPUTS ${CMAKE_CURRENT_SOURCE_DIR}/generic/lib/${file}.ll
)
-install( FILES $ ARCHIVE
- DESTINATION "${CMAKE_INSTALL_DATADIR}/clc" )
+install(
+ FILES ${CMAKE_CURRENT_BINARY_D
@@ -221,8 +221,10 @@ if( ENABLE_RUNTIME_SUBNORMAL )
TARGET ${file}
INPUTS ${CMAKE_CURRENT_SOURCE_DIR}/generic/lib/${file}.ll
)
-install( FILES $ ARCHIVE
- DESTINATION "${CMAKE_INSTALL_DATADIR}/clc" )
+install(
+ FILES ${CMAKE_CURRENT_BINARY_D
@@ -221,8 +221,10 @@ if( ENABLE_RUNTIME_SUBNORMAL )
TARGET ${file}
INPUTS ${CMAKE_CURRENT_SOURCE_DIR}/generic/lib/${file}.ll
)
-install( FILES $ ARCHIVE
- DESTINATION "${CMAKE_INSTALL_DATADIR}/clc" )
+install(
+ FILES ${CMAKE_CURRENT_BINARY_D
@@ -221,8 +221,10 @@ if( ENABLE_RUNTIME_SUBNORMAL )
TARGET ${file}
INPUTS ${CMAKE_CURRENT_SOURCE_DIR}/generic/lib/${file}.ll
)
-install( FILES $ ARCHIVE
- DESTINATION "${CMAKE_INSTALL_DATADIR}/clc" )
+install(
+ FILES ${CMAKE_CURRENT_BINARY_D
https://github.com/frasercrmck edited
https://github.com/llvm/llvm-project/pull/109926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frasercrmck wrote:
Thanks to @aaronpuchert for pointing this out in #87622.
https://github.com/llvm/llvm-project/pull/109926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/frasercrmck created
https://github.com/llvm/llvm-project/pull/109926
The ARCHIVE artifact kind is not valid for install(FILES ...).
Additionally, install wasn't resolving the target's TARGET_FILE properly and
was trying to find it in the top-level build directory, rather tha
12 matches
Mail list logo
