[libclc] [libclc] [cmake] Fix per-target *_convert.cl dependencies (PR #127315)

2025-02-15 Thread Sylvestre Ledru via cfe-commits
sylvestre wrote: I will merge it as it as it fixes https://github.com/llvm/llvm-project/issues/127378 and apt.llvm.org has been broken for a few days because of this This PR can be improved later. https://github.com/llvm/llvm-project/pull/127315 __

[libclc] [libclc] [cmake] Fix per-target *_convert.cl dependencies (PR #127315)

2025-02-15 Thread Sylvestre Ledru via cfe-commits
https://github.com/sylvestre edited https://github.com/llvm/llvm-project/pull/127315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] [cmake] Fix per-target *_convert.cl dependencies (PR #127315)

2025-02-15 Thread Sylvestre Ledru via cfe-commits
https://github.com/sylvestre closed https://github.com/llvm/llvm-project/pull/127315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] [cmake] Fix per-target *_convert.cl dependencies (PR #127315)

2025-02-15 Thread Fraser Cormack via cfe-commits
@@ -249,13 +249,19 @@ function(add_libclc_builtin_set) get_filename_component( file_dir ${file} DIRECTORY ) +if( ARG_ARCH STREQUAL spirv OR ARG_ARCH STREQUAL spirv64 ) + set(CONVERT_DEP clspv-generate_convert.cl) +else() + set(CONVERT_DEP generate_conver

[libclc] [libclc] [cmake] Fix per-target *_convert.cl dependencies (PR #127315)

2025-02-15 Thread Michał Górny via cfe-commits
https://github.com/mgorny edited https://github.com/llvm/llvm-project/pull/127315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] [cmake] Fix per-target *_convert.cl dependencies (PR #127315)

2025-02-15 Thread Sam James via cfe-commits
https://github.com/thesamesam approved this pull request. Please note in the commit message that you're using the same check from `libclc/CMakeLists.txt`. LGTM with that. https://github.com/llvm/llvm-project/pull/127315 ___ cfe-commits mailing list cf

[libclc] [libclc] [cmake] Fix per-target *_convert.cl dependencies (PR #127315)

2025-02-15 Thread Michał Górny via cfe-commits
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/127315 Fix `add_libclc_builtin_set` to add an appropriate dependency to either `clspv-generate_convert.cl` or `generate_convert.cl` based on the `ARCH` argument, rather than to both unconditionally. This fixes build f