everythingfunctional wrote:
> > Not that it's the end of the world if this doesn't get in before the this
> > release, but @sscalpone , exactly what feedback are we wanting before
> > merging?
>
> IIUC, this:
> https://discourse.llvm.org/t/proposal-rename-flang-new-to-flang/69462/55
ok, but
banach-space wrote:
> Not that it's the end of the world if this doesn't get in before the this
> release, but @sscalpone , exactly what feedback are we wanting before merging?
IIUC, this:
https://discourse.llvm.org/t/proposal-rename-flang-new-to-flang/69462/55
https://github.com/llvm/llvm-pr
everythingfunctional wrote:
Not that it's the end of the world if this doesn't get in before the this
release, but @sscalpone , exactly what feedback are we wanting before merging?
https://github.com/llvm/llvm-project/pull/74377
___
cfe-commits mailin
brad0 wrote:
It's all green lights. Anything holding this up?
https://github.com/llvm/llvm-project/pull/74377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
banach-space wrote:
> It appears this PR now has conflicts that need resolving...
Thanks, I've just rebased this branch, so that should be resolved.
https://github.com/llvm/llvm-project/pull/74377
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
https://github.com/banach-space updated
https://github.com/llvm/llvm-project/pull/74377
From 3e77fdd1318c4ea58534a2c1a28ff5e9414b6809 Mon Sep 17 00:00:00 2001
From: Andrzej Warzynski
Date: Sat, 2 Dec 2023 14:01:02 +
Subject: [PATCH 1/4] [flang][driver] Rename `flang-new` as `flang`
This pa
@@ -1,15 +1,15 @@
-! Test that flang-new OpenMP and OpenMP offload related
+! Test that flang OpenMP and OpenMP offload related
! commands forward or expand to the appropriate commands
-! for flang-new -fc1 as expected. Assumes a gfx90a, aarch64,
+! for flang -fc1 as expected.
@@ -27,7 +27,7 @@
! FULL-LTO: "-fc1"
! FULL-LTO-SAME: "-flto=full"
-! THIN-LTO-ALL: flang-new: warning: the option '-flto=thin' is a work in
progress
+! THIN-LTO-ALL: flang-{{[0-9]+}}: warning: the option '-flto=thin' is a work
in progress
MaskRay wrote:
Fo
@@ -15,17 +15,13 @@ local:
```
There are two main drivers in Flang:
h-vetinari wrote:
It might be worth spending a paragraph or section explaining the historical
role of `flang-new`, if only so that people understand why it's (eventually)
not available anym
@@ -193,26 +190,29 @@ driver, `clang -cc1` and consists of the following
classes:
This list is not exhaustive and only covers the main classes that implement the
driver. The main entry point for the frontend driver, `fc1_main`, is
implemented in `flang/tools/flang-driver/drive
banach-space wrote:
> I have a Windows test machine. How can I help?
Thank you for the offer, but it looks like CI is now passing 🥳 @DavidTruby
kindly helped me offline 🙏🏻
https://github.com/llvm/llvm-project/pull/74377
___
cfe-commits mailing list
https://github.com/banach-space updated
https://github.com/llvm/llvm-project/pull/74377
From 1eefb9136ea042e44ada4be66a18b4bf69c18fe3 Mon Sep 17 00:00:00 2001
From: Andrzej Warzynski
Date: Sat, 2 Dec 2023 14:01:02 +
Subject: [PATCH 1/3] [flang][driver] Rename `flang-new` as `flang`
This pa
https://github.com/banach-space updated
https://github.com/llvm/llvm-project/pull/74377
From e5ebda3272925b4f5956c15d0e61f7fbc0016129 Mon Sep 17 00:00:00 2001
From: Andrzej Warzynski
Date: Sat, 2 Dec 2023 14:01:02 +
Subject: [PATCH 1/2] [flang][driver] Rename `flang-new` as `flang`
This pa
banach-space wrote:
> The CI errors are Flang specific on Windows... Do we care about those?
We do care about those, I just need to ping somebody with a Windows machine to
help me fix that.
https://github.com/llvm/llvm-project/pull/74377
___
cfe-comm
rengolin wrote:
The CI errors are Flang specific on Windows... Do we care about those?
https://github.com/llvm/llvm-project/pull/74377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tschuett wrote:
Clang PRs often update the release notes and features.
ala: The LLVM 19 release will not contain flang-new.
https://github.com/llvm/llvm-project/pull/74377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
banach-space wrote:
> Are you going to add an entry to the [Release
> Notes](https://github.com/llvm/llvm-project/blob/main/flang/docs/ReleaseNotes.md)?
Once this change lands, yes.
https://github.com/llvm/llvm-project/pull/74377
___
cfe-commits mail
https://github.com/banach-space created
https://github.com/llvm/llvm-project/pull/74377
This patch renames `flang-new` as `flang`. Similarly to Clang, Flang's
driver executable will be called:
* `flang-`
A symlink called `flang` pointing at `flang-` will be
created at build time. This is con
18 matches
Mail list logo
