https://github.com/tarunprabhu closed
https://github.com/llvm/llvm-project/pull/77360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu updated
https://github.com/llvm/llvm-project/pull/77360
>From ab27280e85d6027e6ff119c0803d962753e83b52 Mon Sep 17 00:00:00 2001
From: Tarun Prabhu
Date: Mon, 8 Jan 2024 10:56:09 -0700
Subject: [PATCH] [flang][Driver] Support -pthread in the frontend
The -pthread
https://github.com/ergawy approved this pull request.
https://github.com/llvm/llvm-project/pull/77360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
luporl wrote:
> Could someone test this on AArch64 and/or Windows just to make sure that it
> passes there?
Works fine on AArch64.
https://github.com/llvm/llvm-project/pull/77360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
tarunprabhu wrote:
> [nit] Note that the test that you've added will run on any platform. Unless
> that's referring to something else?
That was only highlighting that I have not tested this on AArch64 or Windows.
Could someone test this on AArch64 and/or Windows just to make sure that it
pas
banach-space wrote:
> > IIUC, this means that on older system compilation will indeed fail without
> > `-pthread`, but shouldn't be needed on newer systems. @tarunprabhu -
> > perhaps add a link to that article in your test and add a note that on many
> > systems compilation will succeed even
https://github.com/tarunprabhu updated
https://github.com/llvm/llvm-project/pull/77360
>From 187f91dcd9e602c944b089adfb243127c31de2ca Mon Sep 17 00:00:00 2001
From: Tarun Prabhu
Date: Mon, 8 Jan 2024 10:56:09 -0700
Subject: [PATCH 1/2] [flang][Driver] Support -pthread in the frontend
The -pthr
tarunprabhu wrote:
> IIUC, this means that on older system compilation will indeed fail without
> `-pthread`, but shouldn't be needed on newer systems. @tarunprabhu - perhaps
> add a link to that article in your test and add a note that on many systems
> compilation will succeed even without t
banach-space wrote:
Thanks for the input @ergawy !
> That said, what @tarunprabhu mentioned about OpenMPI wrappers adding the flag
> is indeed correct as mentioned by Brian Cornille in the last flang bi-weekly.
> So adding the flag would indeed make sense even if it is redundant for the
> GNU
tarunprabhu wrote:
@banach-space.
Thanks for clarifying. I'll look into creating a test that fails without
`-pthread`.
https://github.com/llvm/llvm-project/pull/77360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tarunprabhu wrote:
Thanks, I am not sure how I missed that.
@banach-space, Is the intention for the `-pthread` option to be illegal in
flang?
At the last flang community call
([2024-01-03](https://docs.google.com/document/d/1Z2U5UAtJ-Dag5wlMaLaW1KRmNgENNAYynJqLW2j2AZQ/edit#heading=h.de8wft8m
banach-space wrote:
Please review the discussion in https://github.com/llvm/llvm-project/pull/75739
before proceeding.
https://github.com/llvm/llvm-project/pull/77360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
llvmbot wrote:
@llvm/pr-subscribers-flang-driver
Author: Tarun Prabhu (tarunprabhu)
Changes
The -pthread option is supported by both clang and gfortran.
The -pthread option seems to be extensively tested for various platforms by
clang. We should be able to piggy-back on those tests since
https://github.com/tarunprabhu created
https://github.com/llvm/llvm-project/pull/77360
The -pthread option is supported by both clang and gfortran.
The -pthread option seems to be extensively tested for various platforms by
clang. We should be able to piggy-back on those tests since we use the
14 matches
Mail list logo
