[PATCH] D59639: [clangd] Print template arguments helper

thakis added inline comments. Comment at: clang-tools-extra/trunk/unittests/clangd/CMakeLists.txt:16 Annotations.cpp + PrintASTTests.cpp BackgroundIndexTests.cpp Keep alphabetized? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.o

Re: [clangd] Print template arguments helper

Thanks Bruno, sent out rL358293 to address the issue. On Fri, Apr 12, 2019 at 5:21 PM Bruno Ricci wrote: > Hi, > > It seems that one of r358272, r358273 or r358274 is causing some asan > failure on my machine. Not sure why it is not spotted by the bots. > > Failure log attached. > > Bruno >

Re: [clangd] Print template arguments helper

Hi, It seems that one of r358272, r358273 or r358274 is causing some asan failure on my machine. Not sure why it is not spotted by the bots. Failure log attached. Bruno FAIL: Extra Tools Unit Tests :: clangd/./ClangdTests/ASTUtilsTests/ASTUtils.PrintTemplateArgs/1 (878 of 1313)

[PATCH] D59639: [clangd] Print template arguments helper

This revision was automatically updated to reflect the committed changes. Closed by commit rL358272: [clangd] Print template arguments helper (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

r358272 - [clangd] Print template arguments helper

Author: kadircet Date: Fri Apr 12 03:09:14 2019 New Revision: 358272 URL: http://llvm.org/viewvc/llvm-project?rev=358272&view=rev Log: [clangd] Print template arguments helper Summary: Prepares ground for printing template arguments as written in the source code, part of re-landing rC356541

[clang-tools-extra] r358272 - [clangd] Print template arguments helper

Author: kadircet Date: Fri Apr 12 03:09:14 2019 New Revision: 358272 URL: http://llvm.org/viewvc/llvm-project?rev=358272&view=rev Log: [clangd] Print template arguments helper Summary: Prepares ground for printing template arguments as written in the source code, part of re-landing rC356541

[PATCH] D59639: [clangd] Print template arguments helper

kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:139 + // location information. + printTemplateArgumentList(OS, Cls->getTemplateArgs().asArray(), Policy); +} ioeric wrote: > Could you also add a test case for this with th

[PATCH] D59639: [clangd] Print template arguments helper

kadircet updated this revision to Diff 194686. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59639/new/ https://reviews.llvm.org/D59639 Files: clang-tools-ex

[PATCH] D59639: [clangd] Print template arguments helper

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang-tools-extra/clangd/AST.cpp:139 + // location information. + printTemplateArgumentList(OS, Cls->getTemplateArgs().asArray(), Policy); +} -

[PATCH] D59639: [clangd] Print template arguments helper

kadircet updated this revision to Diff 194658. kadircet added a comment. - Update file comment for PrintASTTests.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59639/new/ https://reviews.llvm.org/D59639 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D59639: [clangd] Print template arguments helper

kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:133 +printTemplateArgumentList(OS, *Args, Policy); + else if (auto *Cls = llvm::dyn_cast(&ND)) { +if (const TypeSourceInfo *TSI = Cls->getTypeAsWritten()) { ioeric wrote: > kadi

[PATCH] D59639: [clangd] Print template arguments helper

kadircet updated this revision to Diff 194657. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59639/new/ https://reviews.llvm.org/D59639 Files: clang-tools-ex

[PATCH] D59639: [clangd] Print template arguments helper

ioeric added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:149 +} else { + // FIXME: Fix cases when getTypeAsWritten returns null, e.g. friend decls. + printTemplateArgumentList(OS, Cls->getTemplateArgs().asArray(), Policy); I'm not

[PATCH] D59639: [clangd] Print template arguments helper

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:26 +llvm::Optional> +getTemplateSpecializationArgLocs(const NamedDecl &ND) { + if (auto *Func = llvm::dyn_cast(&ND)) { ilya-biryukov wrote: > Eugene.Zelenko wrote: > > Functions s

[PATCH] D59639: [clangd] Print template arguments helper

kadircet updated this revision to Diff 191857. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59639/new/ https://reviews.llvm.org/D59639 Files: clang-tools-ex

[PATCH] D59639: [clangd] Print template arguments helper

kadircet marked 15 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:88 static const TemplateArgumentList * getTemplateSpecializationArgs(const NamedDecl &ND) { if (auto *Func = llvm::dyn_cast(&ND)) ioeric

[PATCH] D59639: [clangd] Print template arguments helper

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:26 +llvm::Optional> +getTemplateSpecializationArgLocs(const NamedDecl &ND) { + if (auto *Func = llvm::dyn_cast(&ND)) { Eugene.Zelenko wrote: > Functions should be static, not in an

[PATCH] D59639: [clangd] Print template arguments helper

ilya-biryukov added inline comments. Comment at: clang-tools-extra/unittests/clangd/ASTUtilsTests.cpp:1 +#include "AST.h" +#include "Annotations.h" NIT: add a licence header Comment at: clang-tools-extra/unittests/clangd/CMakeLists.txt:13 An

[PATCH] D59639: [clangd] Print template arguments helper

ioeric added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1640 + +static void printArgument(const TemplateArgumentLoc &A, + const PrintingPolicy &PP, llvm::raw_ostream &OS) { It's unclear to me what the new behavior is with

[PATCH] D59639: [clangd] Print template arguments helper

ioeric added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:88 static const TemplateArgumentList * getTemplateSpecializationArgs(const NamedDecl &ND) { if (auto *Func = llvm::dyn_cast(&ND)) can we unify this with `getTemplateSpecializationArgL

[PATCH] D59639: [clangd] Print template arguments helper

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:26 +llvm::Optional> +getTemplateSpecializationArgLocs(const NamedDecl &ND) { + if (auto *Func = llvm::dyn_cast(&ND)) { Functions should be static, not in anonymous namespace. See

[PATCH] D59639: [clangd] Print template arguments helper

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. Prepares ground for printing template arguments as written in the source code, part of re-landing rC356541