Re: [clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

2019-07-19 Thread Azhar Mohammed via cfe-commits
Looks good now. Thanks Kadir! > On Jul 19, 2019, at 3:18 AM, Kadir Çetinkaya wrote: > > Hi Azhar, D64980 should fix the problem. I am reverting your revert while > adding the fix in r366559. > > On Fri, Jul 19, 2019 at 11:29 AM Azhar Mohammed > wrote: > Reverted in r36

Re: [clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

2019-07-19 Thread Kadir Çetinkaya via cfe-commits
Hi Azhar, D64980 should fix the problem. I am reverting your revert while adding the fix in r366559. On Fri, Jul 19, 2019 at 11:29 AM Azhar Mohammed wrote: > Reverted in r366551. > > > Revert r366458, r366467 and r366468 > > r366458 is causing test failures. r366467 and r366468 had to be

Re: [clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

2019-07-19 Thread Azhar Mohammed via cfe-commits
Reverted in r366551. Revert r366458, r366467 and r366468 r366458 is causing test failures. r366467 and r366468 had to be reverted as they were casuing conflict while reverting r366458. r366468 [clangd] Remove dead code from BackgroundIndex r366467 [clangd] BackgroundIndex s

Re: [clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

2019-07-18 Thread Azhar Mohammed via cfe-commits
Hi Kadir This change is causing test failures, can you please look into it. Refer to http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/58104/testReport/. Assertion failed: (TUsIt != FileToTU.end() && "No TU registered for the shard"), function takeResult, file /Users/buildslave/j

[clang-tools-extra] r366458 - [clangd] Refactor background-index shard loading

2019-07-18 Thread Kadir Cetinkaya via cfe-commits
Author: kadircet Date: Thu Jul 18 09:25:36 2019 New Revision: 366458 URL: http://llvm.org/viewvc/llvm-project?rev=366458&view=rev Log: [clangd] Refactor background-index shard loading Reviewers: sammccall Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang