Re: [clang-tools-extra] r347498 - [clangd] Add support for hierarchical documentSymbol

2018-11-26 Thread Mikael Holmén via cfe-commits
On 11/26/18 12:41 PM, Ilya Biryukov wrote: > Sorry about that, should be fixed in r347539. > Yep, thanks! /Mikael > On Mon, Nov 26, 2018 at 8:10 AM Mikael Holmén > mailto:mikael.hol...@ericsson.com>> wrote: > > Hi Ilya, > > This patch doesn't compile for me with clang 3.6.0. I get:

Re: [clang-tools-extra] r347498 - [clangd] Add support for hierarchical documentSymbol

2018-11-26 Thread Ilya Biryukov via cfe-commits
Sorry about that, should be fixed in r347539. On Mon, Nov 26, 2018 at 8:10 AM Mikael Holmén wrote: > Hi Ilya, > > This patch doesn't compile for me with clang 3.6.0. I get: > > ../tools/clang/tools/extra/clangd/Protocol.cpp:474:10: error: no viable > conversion from 'json::Object' to 'llvm::json

Re: [clang-tools-extra] r347498 - [clangd] Add support for hierarchical documentSymbol

2018-11-25 Thread Mikael Holmén via cfe-commits
Hi Ilya, This patch doesn't compile for me with clang 3.6.0. I get: ../tools/clang/tools/extra/clangd/Protocol.cpp:474:10: error: no viable conversion from 'json::Object' to 'llvm::json::Value' return Result; ^~ ../include/llvm/Support/JSON.h:291:3: note: candidate constructor n

[clang-tools-extra] r347498 - [clangd] Add support for hierarchical documentSymbol

2018-11-23 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Fri Nov 23 07:21:19 2018 New Revision: 347498 URL: http://llvm.org/viewvc/llvm-project?rev=347498&view=rev Log: [clangd] Add support for hierarchical documentSymbol Reviewers: ioeric, sammccall, simark Reviewed By: sammccall Subscribers: MaskRay, jkorous, arphaman, kadir