Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

2017-01-13 Thread Benjamin Kramer via cfe-commits
Committed r291892. Should also resolve the bogus MSVC warnings. On Fri, Jan 13, 2017 at 12:00 AM, Bill Seurer via cfe-commits wrote: > On 01/10/2017 01:53 PM, Benjamin Kramer wrote: >> >> I didn't manage to reproduce this. Does adding ${PTHREAD_LIB} to >> LINK_LIBS of tools/clang/tools/extra/incl

Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

2017-01-12 Thread Bill Seurer via cfe-commits
On 01/10/2017 01:53 PM, Benjamin Kramer wrote: I didn't manage to reproduce this. Does adding ${PTHREAD_LIB} to LINK_LIBS of tools/clang/tools/extra/include-fixer/plugin/CMakeLists.txt help? That does seem to make it work. On Tue, Jan 10, 2017 at 8:31 PM, Bill Seurer wrote: On 01/09/2017 09

Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

2017-01-10 Thread Galina Kistanova via cfe-commits
Hello Benjamin, It looks like this commit added warnings to the builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/3596 C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\ppltasks.h(1531): warning C4530: C++ exception handler used, but

Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

2017-01-10 Thread Benjamin Kramer via cfe-commits
I didn't manage to reproduce this. Does adding ${PTHREAD_LIB} to LINK_LIBS of tools/clang/tools/extra/include-fixer/plugin/CMakeLists.txt help? On Tue, Jan 10, 2017 at 8:31 PM, Bill Seurer wrote: > On 01/09/2017 09:18 AM, Benjamin Kramer via cfe-commits wrote: >> >> Author: d0k >> Date: Mon Jan

Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

2017-01-10 Thread Bill Seurer via cfe-commits
On 01/09/2017 09:18 AM, Benjamin Kramer via cfe-commits wrote: Author: d0k Date: Mon Jan 9 09:18:28 2017 New Revision: 291446 URL: http://llvm.org/viewvc/llvm-project?rev=291446&view=rev Log: [include-fixer] Load symbol index asynchronously. We don't actually need the index until parse time, s

[clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

2017-01-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jan 9 09:18:28 2017 New Revision: 291446 URL: http://llvm.org/viewvc/llvm-project?rev=291446&view=rev Log: [include-fixer] Load symbol index asynchronously. We don't actually need the index until parse time, so fetch it in the background and start parsing. By the time it is