Re: [clang-tools-extra] r270472 - Commiting for http://reviews.llvm.org/D20365

2016-05-23 Thread Mads Ravn via cfe-commits
@Nico, Yes, I will. I'm sorry about that. I had mistakenly read that it would take the title and commit message from phabricator if I linked to that in my svn commit message. @Piotr, A test failed to build on the build server (as shown on IRC), so I quickly reverted the commit. I will remember bet

Re: [clang-tools-extra] r270472 - Commiting for http://reviews.llvm.org/D20365

2016-05-23 Thread Piotr Padlewski via cfe-commits
BTW why did you revert this change? And why the commit message doesn't have "revert" in name? 2016-05-23 20:51 GMT+02:00 Nico Weber via cfe-commits < cfe-commits@lists.llvm.org>: > Next time, please use real commit messages: Describe what the change does, > and why it's being done. Include a link

Re: [clang-tools-extra] r270472 - Commiting for http://reviews.llvm.org/D20365

2016-05-23 Thread Nico Weber via cfe-commits
Next time, please use real commit messages: Describe what the change does, and why it's being done. Include a link to the review link at the end of the commit message. If every change just had a phab link as commit message, people bisecting changes would have to click through for every change in `s

[clang-tools-extra] r270472 - Commiting for http://reviews.llvm.org/D20365

2016-05-23 Thread Mads Ravn via cfe-commits
Author: madsravn Date: Mon May 23 13:15:40 2016 New Revision: 270472 URL: http://llvm.org/viewvc/llvm-project?rev=270472&view=rev Log: Commiting for http://reviews.llvm.org/D20365 Modified: clang-tools-extra/trunk/clang-tidy/modernize/PassByValueCheck.cpp clang-tools-extra/trunk/test/clan