Re: [clang-tools-extra] r262257 - IdentifierNamingCheck.cpp: try to fix MSVC build

2016-03-01 Thread Hans Wennborg via cfe-commits
I only noticed this when I tried to build the weekly Windows snapshot, and I didn't build one last week, so I don't know exactly when it started failing. As you said, it might be due to a header change somewhere. Since this was inside a DEBUG(), I suppose it would only show in builds with asserts e

Re: [clang-tools-extra] r262257 - IdentifierNamingCheck.cpp: try to fix MSVC build

2016-03-01 Thread Alexander Kornienko via cfe-commits
Thanks for the fix! When did it start failing? The last change in this file was quite a while ago. Did it start breaking because of a change in a header? On Mon, Feb 29, 2016 at 10:17 PM, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Mon Feb 29 15:17:39

[clang-tools-extra] r262257 - IdentifierNamingCheck.cpp: try to fix MSVC build

2016-02-29 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Feb 29 15:17:39 2016 New Revision: 262257 URL: http://llvm.org/viewvc/llvm-project?rev=262257&view=rev Log: IdentifierNamingCheck.cpp: try to fix MSVC build It was failing to build with: clang-tidy\readability\IdentifierNamingCheck.cpp(640): error C2882: 'format' : illegal