[clang-tools-extra] Fix crash in modernize-use-ranges (PR #100427)

2024-09-23 Thread via cfe-commits
tupos wrote: I posted comment on the backport change, but probably here is a better way https://github.com/llvm/llvm-project/pull/101482#issuecomment-2368039230 https://github.com/llvm/llvm-project/pull/100427 ___ cfe-commits mailing list cfe-commits@

[clang-tools-extra] Fix crash in modernize-use-ranges (PR #100427)

2024-07-25 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/100427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix crash in modernize-use-ranges (PR #100427)

2024-07-25 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: Fix is reported to work, so lets merge it. https://github.com/llvm/llvm-project/pull/100427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix crash in modernize-use-ranges (PR #100427)

2024-07-24 Thread Piotr Zegar via cfe-commits
@@ -123,32 +108,34 @@ makeMatcherPair(StringRef State, const UseRangesCheck::Indexes &Indexes, } void UseRangesCheck::registerMatchers(MatchFinder *Finder) { - Replaces = getReplacerMap(); + auto Replaces = getReplacerMap(); ReverseDescriptor = getReverseDescriptor();

[clang-tools-extra] Fix crash in modernize-use-ranges (PR #100427)

2024-07-24 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/100427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix crash in modernize-use-ranges (PR #100427)

2024-07-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Nathan James (njames93) Changes Crash seems to be caused by the check function not handling inline namespaces correctly for some instances. Changed how the Replacer is got from the MatchResult now which should alleviate any po

[clang-tools-extra] Fix crash in modernize-use-ranges (PR #100427)

2024-07-24 Thread Nathan James via cfe-commits
njames93 wrote: No release notes added as this will likely want to get backported https://github.com/llvm/llvm-project/pull/100427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix crash in modernize-use-ranges (PR #100427)

2024-07-24 Thread Nathan James via cfe-commits
https://github.com/njames93 created https://github.com/llvm/llvm-project/pull/100427 Crash seems to be caused by the check function not handling inline namespaces correctly for some instances. Changed how the Replacer is got from the MatchResult now which should alleviate any potential issues