bjope wrote:
> > I guess I don't know how pull requests and reviewing works in github. I
> > actually added 3 comments on this patch a several days (or weeks) ago. But
> > turns out that they were "pending" because I had only "started review" and
> > not found the place to "submit review".
>
@@ -935,7 +935,7 @@ bool
AArch64ConditionalCompares::runOnMachineFunction(MachineFunction &MF) {
SchedModel = MF.getSubtarget().getSchedModel();
MRI = &MF.getRegInfo();
DomTree = &getAnalysis();
- Loops = getAnalysisIfAvailable();
+ Loops = &getAnalysis();
@@ -261,7 +261,7 @@ bool VirtRegRewriter::runOnMachineFunction(MachineFunction
&fn) {
Indexes = &getAnalysis();
LIS = &getAnalysis();
VRM = &getAnalysis();
- DebugVars = getAnalysisIfAvailable();
+ DebugVars = &getAnalysis();
jayfoad wrote:
Thanks! Fi
@@ -3280,7 +3280,7 @@ class llvm::gvn::GVNLegacyPass : public FunctionPass {
if (skipFunction(F))
return false;
-auto *LIWP = getAnalysisIfAvailable();
+auto &LIWP = getAnalysis();
jayfoad wrote:
I prefer not to leave it as is - I think eith
@@ -3280,7 +3280,7 @@ class llvm::gvn::GVNLegacyPass : public FunctionPass {
if (skipFunction(F))
return false;
-auto *LIWP = getAnalysisIfAvailable();
+auto &LIWP = getAnalysis();
bjope wrote:
IIUC GVN doesn't depend on LoopInfo itself. It
https://github.com/bjope commented:
I guess I don't know how pull requests and reviewing works in github. I
actually added 3 comments on this patch a several days (or weeks) ago. But
turns out that they were "pending" because I had only "started review" and not
found the place to "submit revie
https://github.com/bjope edited https://github.com/llvm/llvm-project/pull/65729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/65729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
